ci: PR-3 - typecheck, unit, live three-storefront matrix, audit, build - #3
Merged
Merged
Conversation
…t, build GitHub Actions on every PR and main push — the Links CI recipe adapted: - npm ci → tsc --noEmit → unit suites (campaigns, config, render) - pip-installs nedb-engine, boots a REAL nedbd (health-polled), then runs the live suite: the same build booted once per campaign in-process, asserting identity, health, robots.txt, sitemap.xml per storefront - portal audit as a blocking contract gate (currently green: 2 warnings, 0 failures — warnings tighten to failures as Phase 1 content lands) - portal build proves the production pipeline - engine log dumped on failure Single-quoted expressions only in workflow expressions (the double-quote startup_failure gotcha is documented ecosystem-wide). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR-3 of Phase 0: CI. Every PR now proves — on a real engine — that all three storefronts still stand.
Why this matters
The three-campaign live matrix runs on every change from here forward: typecheck, unit suites, the live suite against a pip-booted real nedbd (no mocks, house rule),
portal auditas a blocking contract gate, and the production build. A regression in any storefront reds the PR that caused it.What's inside
.github/workflows/ci.yml— single job:npm ci→ typecheck → unit (campaigns · config · render) → boot nedbd via pip + health poll → live matrix (NEDB_TEST_URL) →portal audit→portal build, engine log on failure. Adapted from the proven nedb-links recipe.Tests run
This PR's own CI run is the test — the workflow proves itself before merge (verified green before this PR was merged, per house rule: no claiming green off in-progress runs).
Local pre-flight:
portal auditexits 0 today (2 SEO warnings on the shell page, 0 failures — the warnings are Phase 1's content job, listed as follow-ups).Follow-up work
Spec: §12 (testing strategy), §15 (roadmap PR-3).