Revert "fix: reject payment when recipient trusts wrong issuer"

.gitignore

@@ -1,6 +1,3 @@
 .repo-history-backups/
-temp_auto_push.bat
 .claude/
 
-.gitignore
-branch_structure.json

esure-backend/scenarios/issued-asset-payment.json

@@ -1,27 +1,23 @@
 {
   "schemaVersion": 1,
   "id": "issued-asset-payment",
-  "version": 2,
+  "version": 1,
   "name": "Issued asset payment",
-  "description": "Two issued assets share the code TESTUSD but have distinct issuer references. The recipient holds a trustline only to the first issuer, so a payment of the second issuer's TESTUSD must be rejected: a matching asset code is not enough because the issuer identity is part of the asset. The payment must fail with the precise missing-trustline error for the actual second issuer, and the recipient's existing trustline to the first issuer must remain present with its balance unchanged.",
+  "description": "Issue TESTUSD and send it to a recipient through a trustline.",
   "network": "testnet",
   "accounts": [
-    { "id": "issuer-one", "generate": true, "fund": true },
-    { "id": "issuer-two", "generate": true, "fund": true },
+    { "id": "issuer", "generate": true, "fund": true },
     { "id": "recipient", "generate": true, "fund": true }
   ],
   "assets": [
     { "id": "xlm", "type": "native" },
-    { "id": "test-usd-one", "type": "issued", "code": "TESTUSD", "issuer": "issuer-one" },
-    { "id": "test-usd-two", "type": "issued", "code": "TESTUSD", "issuer": "issuer-two" }
+    { "id": "test-usd", "type": "issued", "code": "TESTUSD", "issuer": "issuer" }
   ],
   "steps": [
-    { "id": "create-trustline", "type": "changeTrust", "account": "recipient", "asset": "test-usd-one" },
-    { "id": "send-testusd", "type": "payment", "from": "issuer-two", "to": "recipient", "asset": "test-usd-two", "amount": "100", "expectedError": { "code": "MISSING_TRUSTLINE", "account": "recipient", "asset": "test-usd-two", "issuer": "issuer-two" } }
+    { "id": "create-trustline", "type": "changeTrust", "account": "recipient", "asset": "test-usd" },
+    { "id": "send-testusd", "type": "payment", "from": "issuer", "to": "recipient", "asset": "test-usd", "amount": "100" }
   ],
   "assertions": [
-    { "type": "trustlineExists", "account": "recipient", "asset": "test-usd-one" },
-    { "type": "balanceEquals", "account": "recipient", "asset": "test-usd-one", "amount": "0" },
-    { "type": "trustlineMissing", "account": "recipient", "asset": "test-usd-two" }
+    { "type": "balanceEquals", "account": "recipient", "asset": "test-usd", "amount": "100" }
   ]
 }

esure-backend/scenarios/missing-trustline.yaml

@@ -2,20 +2,10 @@ schemaVersion: 1
 id: missing-trustline
 version: 1
 name: Missing trustline
-description: >-
-  Verify that an asset payment fails when the recipient has no trustline.
-  Two issued assets share the same code TESTUSD but are issued by distinct
-  issuer accounts. The recipient trusts only the first issuer, so a payment
-  using the second issuer's asset must fail with a missing-trustline
-  operation code. This exercises issuer-aware failure matching: a matching
-  asset code alone must not satisfy the trustline requirement, because the
-  recipient's trustline is bound to a different issuer identity.
+description: Verify that an asset payment fails when the recipient has no trustline.
 network: testnet
 accounts:
-  - id: issuer-a
-    generate: true
-    fund: true
-  - id: issuer-b
+  - id: issuer
     generate: true
     fund: true
   - id: recipient
@@ -24,35 +14,20 @@ accounts:
 assets:
   - id: xlm
     type: native
-  - id: test-usd-a
-    type: issued
-    code: TESTUSD
-    issuer: issuer-a
-  - id: test-usd-b
+  - id: test-usd
     type: issued
     code: TESTUSD
-    issuer: issuer-b
+    issuer: issuer
 steps:
-  - id: trust-testusd-a
-    type: changeTrust
-    account: recipient
-    asset: test-usd-a
-    limit: "1000"
-  - id: send-testusd-b
+  - id: send-testusd
     type: payment
-    from: issuer-b
+    from: issuer
     to: recipient
-    asset: test-usd-b
+    asset: test-usd
     amount: "100"
 assertions:
   - type: stepFailedWith
-    step: send-testusd-b
+    step: send-testusd
     transactionCode: tx_failed
     operationCodes:
       - op_no_trust
-  - type: trustlineExists
-    account: recipient
-    asset: test-usd-a
-  - type: trustlineBalanceUnchanged
-    account: recipient
-    asset: test-usd-a

esure-backend/src/scenario-schema.ts

@@ -100,7 +100,7 @@ function validateSafeValues(value: unknown): void {
   const visit = (item: unknown, path: string): void => {
     if (typeof item === "string") {
       if (/S[A-Z2-7]{55}/.test(item)) issues.push(`${path} must not contain a Stellar secret seed`);
-      if (/\b(?:https|ftp|file):\/\//i.test(item)) issues.push(`${path} must not contain a URL`);
+      if (/\b(?:https?|ftp|file):\/\//i.test(item)) issues.push(`${path} must not contain a URL`);
       return;
     }
     if (Array.isArray(item)) { item.forEach((child, index) => visit(child, `${path}/${index}`)); return; }
@@ -184,19 +184,11 @@ function validateReferences(scenario: ScenarioDefinition): void {
       if (new Set(step.path).size !== step.path.length) issues.push(`step ${step.id} path contains duplicate assets`);
       for (const assetId of step.path) {
         if (!assets.has(assetId)) issues.push(`step ${step.id} references unknown path asset ${assetId}`);
+        if (assetId === step.sendAsset || assetId === step.destAsset) issues.push(`step ${step.id} path must contain only intermediate assets`);
       }
     }
   }
-  for (const assertion of scenario.assertions) {
-    if (assertion.type === "transactionMemoEquals" || assertion.type === "stepSucceeded" || assertion.type === "transactionConfirmed" || assertion.type === "stepFailedWith") {
-      if (!steps.has(assertion.step)) issues.push(`assertion ${assertion.type} references unknown step ${assertion.step}`);
-    } else if (assertion.type === "accountExists") {
-      if (!accounts.has(assertion.account)) issues.push(`assertion accountExists references unknown account ${assertion.account}`);
-    } else {
-      if (!accounts.has(assertion.account)) issues.push(`assertion ${assertion.type} references unknown account ${assertion.account}`);
-      if (!assets.has(assertion.asset)) issues.push(`assertion ${assertion.type} references unknown asset ${assertion.asset}`);
-    }
-  }
+  for (const assertion of scenario.assertions) validateAssertionReferences(assertion, accounts, assets, steps, scenario, issues);
   if (issues.length) throw new ScenarioValidationError(issues);
 }
 
@@ -219,18 +211,14 @@ function validateAssertionReferences(assertion: ScenarioAssertion, accounts: Set
 }
 
 function uniqueIds(items: readonly { id: string }[], label: string, issues: string[]): Set<string> {
-  const seen = new Set<string>();
+  const ids = new Set<string>();
   for (const item of items) {
-    if (seen.has(item.id)) issues.push(`${label} contains duplicate id ${item.id}`);
-    seen.add(item.id);
+    if (ids.has(item.id)) issues.push(`${label} contains duplicate id ${item.id}`);
+    ids.add(item.id);
   }
-  return seen;
+  return ids;
 }
 
-function formatAjvErrors(errors: ErrorObject[] | null): string[] {
-  if (!errors) return [];
-  return errors.map((error) => {
-    const path = error.instancePath || "/";
-    return `${path} ${error.message ?? "is invalid"}`;
-  });
-}
+function formatAjvErrors(errors: ErrorObject[] | null | undefined): string[] {
+  return (errors ?? []).slice(0, 50).map((error) => `${error.instancePath || "/"} ${error.message ?? "is invalid"}`);
+}