Repository navigation
fix: reject payment when recipient trusts wrong issuer - #149
Merged
udoyechinenyevictoria merged 3 commits intoOct 23, 2026
Conversation
|
@Raydev-tech Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@Raydev-tech is attempting to deploy a commit to the Favour Chigozirim's projects Team on Vercel. A member of the Team first needs to authorize it. |
Raydev-tech
force-pushed
the
feat/issue-106-scenarios-reject-a-payment-when-the-recipient
branch
from
October 22, 2026 01:37
09f0902 to
3c0d0f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR makes issued-asset payment scenarios issuer-aware. Previously a payment could appear valid because the asset code matched, even when the recipient's trustline belonged to a different issuer. The scenario now defines two same-code assets with distinct issuers, pays using the untrusted issuer, and asserts the precise missing-trustline failure for that issuer while confirming the existing trustline and its balance are untouched.
Related Issue
Changes
🔍 Issuer-Aware Scenario Validation
[MODIFY]
esure-backend/src/stellar-gateway.ts[MODIFY]
esure-backend/src/stellar-error-interpreter.ts[MODIFY]
esure-backend/src/scenario-schema.ts📄 Scenario Definitions
[MODIFY]
esure-backend/scenarios/issued-asset-payment.json[MODIFY]
esure-backend/scenarios/missing-trustline.yaml📚 Docs & Tests
[MODIFY]
esure-docs/SCENARIOS.md[MODIFY]
esure-backend/test/scenario-schema.test.tsVerification Results
missing-trustline.yamlSCENARIOS.mdCloses #106