Conversation
Contributor
|
Thanks for the PR. will review later - we are very busy atm Appreciate concise PR, and the tests. |
Contributor
|
Blocking issue: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The wallet currently requires either an interactive password prompt or the
--passcommand-line option. This makes unattended operation difficult, while--passexposes the wallet password through the process command line.This change adds support for the
EPIC_WALLET_PASSWORD_FILEenvironmentvariable. When set, the wallet reads the password from the referenced file.
Password selection priority is:
--passEPIC_WALLET_PASSWORD_FILETrailing CR/LF characters are removed from the password file so that files
ending with a normal newline can be used without modifying the password.
Existing interactive behavior remains unchanged.
Type of change
How Has This Been Tested?
cargo test --release password_from_file -- --nocapturecargo build --releaseepic-wallet listen -m http -nwith the password supplied throughEPIC_WALLET_PASSWORD_FILERelevant notes
The existing
--passoption keeps precedence over the environment variable.If
EPIC_WALLET_PASSWORD_FILEis not set, the wallet continues to use theexisting interactive password prompt.