Conversation
Benchmark Results
Benchmark PlotsA plot of the benchmark results has been uploaded as an artifact at https://github.com/EnzymeAD/Enzyme.jl/actions/runs/25424767044/artifacts/6825955217. |
|
Sigh it seems necessary for 1.10 test to pass. |
|
is there a reason for doing this since we already have the ref option? I agree this is nicer, but technically breaking |
Attributor is turned off already by default for 1.12 and as #3041 shows causes compilation issues that are really frustrating to debug in 1.11 (I spent ~4days trying to root cause that bug this week). So yes as CI shows it sometimes does positive things, but it also continuously seems to create deeply frustrating bugs and I for one had enough of it. |
|
oh I meant more in reference to it being a preference vs the current ref [not wrt the default or not]. we should look at the remaining failure with 1.11 when disabled. part of why its okay to turn off is ive been slowly making an "attributor lite" pass for our specific needs, though not as aggressive |
I think that's fine. We are promoting it from an internal interface, to something more official and documented. |
Add src/preferences.jl with documented run_attributor() getter and set_run_attributor!() setter, defaulting to false. Export both from the top-level Enzyme module. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Document the attributor pass in faq.md with a description of what it does, why it defaults to false, and how to use run_attributor() and set_run_attributor!(). Add a basic test for the preference round-trip. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Valentin Churavy <v.churavy@gmail.com>
Attributor yet again seems to be the cause of some illegal code transformation,
and I would like my last few days of investigating #3041 (comment) back.
This PR turns running it into an preference flag (so that folks who want it don't need to remember passing an environment flag),
but turns it off by default.