Conversation
wsmoses
reviewed
Apr 30, 2026
| additionalArg, | ||
| typeInfo, | ||
| uncacheable_args, | ||
| aug = C_NULL, |
Member
There was a problem hiding this comment.
is there a jll change for this?
Member
Author
There was a problem hiding this comment.
Why would there be? The C-API has already accepted this parameter and we are just exposing it to the user here?
Implements DEM_ForwardModeSplit (value 4 in CApi.h) which splits forward
mode AD into two separate LLVM functions — an augmented forward pass
(runs primal, stores tape) and a forward derivative pass (takes tape,
returns shadow) — mirroring ReverseModeSplit for the reverse case.
Changes:
- EnzymeCore: add ForwardModeSplit mode type, ForwardSplitNoPrimal /
ForwardSplitWithPrimal constants, and ForwardSplitWidth/Modified helpers
- api.jl: DEM_ForwardModeSplit = 4, extend EnzymeCreateForwardDiff with
aug parameter for split mode
- compiler.jl: ForwardModeSplitThunk struct; thunkbase branch calling
EnzymeCreateAugmentedPrimal then EnzymeCreateForwardDiff(split);
ABI wrapper and enzyme_call flags; fix AugmentedForwardThunk rettype to
Const{actualRetType} so the primal-only augmented forward wrapper does
not attempt to extract a shadow
- interpreter.jl, reflection.jl: treat DEM_ForwardModeSplit like
DEM_ForwardMode (forward rules, Forward dispatch)
- Enzyme.jl: autodiff_thunk(::ForwardModeSplit, ...) returning
(AugmentedForwardThunk, ForwardModeSplitThunk)
- errors.jl, customrules.jl, parallelrules.jl, activity.jl: extend all
DEM_ForwardMode-only checks to also cover DEM_ForwardModeSplit
- test/forwardmodesplit.jl: new test file (42 tests)
- test/tests.jl: internal thunk tests for DEM_ForwardModeSplit
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements DEM_ForwardModeSplit (value 4 in CApi.h) which splits forward
mode AD into two separate LLVM functions — an augmented forward pass
(runs primal, stores tape) and a forward derivative pass (takes tape,
returns shadow) — mirroring ReverseModeSplit for the reverse case.
Changes:
ForwardSplitWithPrimal constants, and ForwardSplitWidth/Modified helpers
aug parameter for split mode
EnzymeCreateAugmentedPrimal then EnzymeCreateForwardDiff(split);
ABI wrapper and enzyme_call flags; fix AugmentedForwardThunk rettype to
Const{actualRetType} so the primal-only augmented forward wrapper does
not attempt to extract a shadow
DEM_ForwardMode (forward rules, Forward dispatch)
(AugmentedForwardThunk, ForwardModeSplitThunk)
DEM_ForwardMode-only checks to also cover DEM_ForwardModeSplit
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com