Fix typos#2983
Conversation
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/src/compiler.jl b/src/compiler.jl
index 0561a874..165d22e3 100644
--- a/src/compiler.jl
+++ b/src/compiler.jl
@@ -3360,7 +3360,7 @@ function create_abi_wrapper(
# Enzyme expects, arg, [w x darg], root, droot
# Julia expects arg, root, darg, droot
# We already pushed arg
- # now params[i] refers to root
+ # now params[i] refers to root
darg = nothing
root = nothing
droot = nothing
@@ -6599,7 +6599,7 @@ const DumpLLVMCall = Ref(false)
tape = callparams[end-1]
end
if value_type(tape) != llty
- throw(AssertionError("Mismatched Tape type, expected $(string(value_type(tape))) found $(string(llty)) from $TapeType arg_roots=$arg_roots"))
+ throw(AssertionError("Mismatched Tape type, expected $(string(value_type(tape))) found $(string(llty)) from $TapeType arg_roots=$arg_roots"))
end
end
end
diff --git a/src/utils.jl b/src/utils.jl
index 328a1602..dae5a156 100644
--- a/src/utils.jl
+++ b/src/utils.jl
@@ -145,8 +145,8 @@ function unsafe_to_llvm(B::LLVM.IRBuilder, @nospecialize(val); insert_name_if_no
if !inactive && world isa UInt
legal, jTy, byref = Compiler.abs_typeof(gv, true)
if legal
- current_bb = position(B)
- fn = LLVM.parent(current_bb)
+ current_bb = position(B)
+ fn = LLVM.parent(current_bb)
state = Enzyme.Compiler.active_reg(jTy, world)
inactive = state == Enzyme.Compiler.AnyState ||state == Enzyme.Compiler.ActiveState
end |
|
|
||
| struct CompilerInstance | ||
| jit::LLVM.JuliaOJIT | ||
| lctm::Union{LLVM.LazyCallThroughManager,Nothing} |
There was a problem hiding this comment.
this PR modifies way too much, you shouldn't modify the code (here formatting) that you aren't intending to fix
There was a problem hiding this comment.
Thanks! I will be reverting the changes that don't directly work on the typo lines, in about a month or so. (Time constraints 😞)
Marking this PR as draft until then
cc05f21 to
5dedf92
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2983 +/- ##
=======================================
Coverage 69.53% 69.53%
=======================================
Files 66 66
Lines 21577 21577
=======================================
Hits 15003 15003
Misses 6574 6574 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
gentle bump @wsmoses |
Housekeeping edits: Fix up typos.
Update: also ran runic on the changed files after CI workflow