Skip to content

Fix typos#2983

Open
abhro wants to merge 1 commit intoEnzymeAD:mainfrom
abhro:typos
Open

Fix typos#2983
abhro wants to merge 1 commit intoEnzymeAD:mainfrom
abhro:typos

Conversation

@abhro
Copy link
Copy Markdown
Contributor

@abhro abhro commented Feb 25, 2026

Housekeeping edits: Fix up typos.

Update: also ran runic on the changed files after CI workflow

@abhro abhro changed the title Fix Typos Fix typos Feb 25, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 25, 2026

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic main) to apply these changes.

Click here to view the suggested changes.
diff --git a/src/compiler.jl b/src/compiler.jl
index 0561a874..165d22e3 100644
--- a/src/compiler.jl
+++ b/src/compiler.jl
@@ -3360,7 +3360,7 @@ function create_abi_wrapper(
 	    # Enzyme expects, arg, [w x darg], root, droot
 	    # Julia expects   arg, root, darg, droot
 	    # We already pushed arg
-	    # now params[i] refers to root
+            # now params[i] refers to root
 	    darg = nothing
 	    root = nothing
 	    droot = nothing
@@ -6599,7 +6599,7 @@ const DumpLLVMCall = Ref(false)
                     tape = callparams[end-1]
                 end
 		if value_type(tape) != llty
-		   throw(AssertionError("Mismatched Tape type, expected $(string(value_type(tape))) found $(string(llty)) from $TapeType arg_roots=$arg_roots"))
+                    throw(AssertionError("Mismatched Tape type, expected $(string(value_type(tape))) found $(string(llty)) from $TapeType arg_roots=$arg_roots"))
 		end
             end
         end
diff --git a/src/utils.jl b/src/utils.jl
index 328a1602..dae5a156 100644
--- a/src/utils.jl
+++ b/src/utils.jl
@@ -145,8 +145,8 @@ function unsafe_to_llvm(B::LLVM.IRBuilder, @nospecialize(val); insert_name_if_no
 	    if !inactive && world isa UInt
                 legal, jTy, byref = Compiler.abs_typeof(gv, true)
                 if legal
-                    current_bb = position(B)
-                    fn = LLVM.parent(current_bb)
+                current_bb = position(B)
+                fn = LLVM.parent(current_bb)
 		    state = Enzyme.Compiler.active_reg(jTy, world)
 		    inactive = state == Enzyme.Compiler.AnyState ||state == Enzyme.Compiler.ActiveState
                 end

Comment thread src/compiler/orcv2.jl

struct CompilerInstance
jit::LLVM.JuliaOJIT
lctm::Union{LLVM.LazyCallThroughManager,Nothing}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR modifies way too much, you shouldn't modify the code (here formatting) that you aren't intending to fix

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I will be reverting the changes that don't directly work on the typo lines, in about a month or so. (Time constraints 😞)
Marking this PR as draft until then

@abhro abhro marked this pull request as draft March 4, 2026 03:22
@abhro abhro force-pushed the typos branch 2 times, most recently from cc05f21 to 5dedf92 Compare March 18, 2026 16:39
@abhro abhro marked this pull request as ready for review March 18, 2026 16:41
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 28, 2026

Codecov Report

❌ Patch coverage is 57.62712% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.53%. Comparing base (0f8b25f) to head (199ddc7).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/jlrt.jl 52.17% 22 Missing ⚠️
src/compiler.jl 40.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2983   +/-   ##
=======================================
  Coverage   69.53%   69.53%           
=======================================
  Files          66       66           
  Lines       21577    21577           
=======================================
  Hits        15003    15003           
  Misses       6574     6574           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@abhro
Copy link
Copy Markdown
Contributor Author

abhro commented Apr 13, 2026

gentle bump @wsmoses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants