Reinstate EnsureIndexAsync implementation with CREATE INDEX logic - #9
Merged
Merged
Conversation
Co-authored-by: mrdevrobot <12503462+mrdevrobot@users.noreply.github.com>
Co-authored-by: mrdevrobot <12503462+mrdevrobot@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issues in snapshot persistence feature based on review feedback
Reinstate EnsureIndexAsync implementation with CREATE INDEX logic
Jan 26, 2026
mrdevrobot
approved these changes
Jan 26, 2026
mrdevrobot
marked this pull request as ready for review
January 26, 2026 22:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
EnsureIndexAsyncmethod inSqlitePeerStorewas reduced to a no-op placeholder, breaking theIPeerStorecontract and the existing testEnsureIndexAsync_ShouldCreateIndexWithoutError. This method is expected to create SQLite indexes to optimize queries on document properties.Type of change
Changes
Restored Index Creation Logic
EnsureIndexAsyncimplementation that creates SQLite indexes usingCREATE INDEX IF NOT EXISTSSecurity Fix
Compilation Fix
GetCollectionsAsyncto use_options?.UsePerCollectionTables == trueinstead of non-existentUsePerCollectionTablespropertyHow Has This Been Tested?
EnsureIndexAsync_ShouldCreateIndexWithoutError- verifies indexes can be created without errorsChecklist:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.