[master][WIP][BR001026][T23820] suez mobile framework - #1
Open
JoJoJoJoJoJoJo wants to merge 11 commits into
Open
[master][WIP][BR001026][T23820] suez mobile framework#1JoJoJoJoJoJoJo wants to merge 11 commits into
JoJoJoJoJoJoJo wants to merge 11 commits into
Conversation
elicoidal
reviewed
May 28, 2018
elicoidal
left a comment
elicoidal
left a comment
There was a problem hiding this comment.
LGTM (short size PR and overall).
Cannot judge the validity of the technical part though
@seb-elico @lonelysun will need to review
seb-elico
suggested changes
Jun 5, 2018
seb-elico
left a comment
seb-elico
left a comment
There was a problem hiding this comment.
@JoJoJoJoJoJoJo Good job! Just a few comments
| */ | ||
| package com.odoo.config; | ||
|
|
||
|
|
| * OAddon partners = new OAddon(Partners.class).withSequence(2); | ||
| */ | ||
| OAddon customers = new OAddon(Customers.class).setDefault(); | ||
| // OAddon customers = new OAddon(Customers.class).setDefault(); |
There was a problem hiding this comment.
Remove dead code and add comment to explain what is the below line
| super.onCreate(); | ||
| App.APPLICATION_NAME = getPackageManager().getApplicationLabel(getApplicationInfo()).toString(); | ||
| App.modelRegistryUtils.makeReady(getApplicationContext()); | ||
| networkState = inNetwork(); |
| for (Enumeration<String> item = dexFile.entries(); item.hasMoreElements(); ) { | ||
| String element = item.nextElement(); | ||
| if (element.startsWith(App.class.getPackage().getName())) { | ||
| if (element.startsWith(App.class.getPackage().getName()) || element.startsWith(OConstants.SUEZ_APP_PACKAGE)) { |
| } | ||
|
|
||
| public List<ODataRow> searchRecords(OdooFields fields, ODomain domain, int limit) { | ||
| public List<ODataRow> searchRecords(OdooFields fields, ODomain domain, int offset, int limit, String sort) { |
| return searchRecords(fields, domain, limit, null); | ||
| } | ||
|
|
||
|
|
| this.relationType = relationType; | ||
| } | ||
|
|
||
| public OColumn(Context context, int resId, Class<?> type) { |
There was a problem hiding this comment.
Based on code, seems like <?> should be replaced with <BaseFragment>
| this(OResource.string(context, resId), type); | ||
| } | ||
|
|
||
| public OColumn(Context context, int resId, Class<?> type, RelationType relationType) { |
| addon = addon_class; | ||
| } | ||
|
|
||
| public OAddon(String clsName) { |
| addon = cls; | ||
| } | ||
| } catch (ClassNotFoundException e) { | ||
| e.printStackTrace(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.