Repository navigation
Conversation
…ts from 3/4 of the bytes TF_DS_RS=1 (two ranks, off by default): a prompt chunk's attention and MoE partials reach the mHC post as bf16(p0 + p1), from an fp32 reduce-scatter and a bf16 all-gather, instead of the fp32 all-gather. The post kernels add the two ranks' rows and round to bf16; one fp32 add of two operands has the same bits in either order, so they form the same y. Odd row counts, rows the RDMA gather holds, and one rank keep the gather.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Effect
TF_DS_RS=1, 31.7-32.0 s with it off, in alternating rounds.--alone --serialequal in every cell.Reproduce
TF_DS_SPILL_GIB=0), two rounds each way.Change
NCCL.reduce_scatterandComm.reduced: prompt partials reach the mHC post as bf16(p0 + p1) from an fp32 reduce-scatter and a bf16 all-gather, 3/4 of the bytes.Why
Type
type: feature: new code (a feature, tool or add-on)Tests
tests/test_dsv41_reduced.py: 5 passed in the engine image, 2 skipped without torch or triton.Checklist
AI disclosure
AI: Claude Opus 5.5 via Hermes Agent
Checked: by author