Angular 22 - #206
Merged
Merged
Angular 22#206
Conversation
Amongst other things, this update eslint and their rules, helping us prepare for incoming Angular 22.
Except: - @types/node, we run on node 22 - typescript, angular is not ready
There was a problem hiding this comment.
Pull request overview
Upgrades the workspace and published library to Angular 22, switching the demo app to zoneless change detection and migrating unit tests from Karma/Jasmine to the Angular unit-test builder with Vitest.
Changes:
- Bump Angular (and related tooling) dependencies to
22.1.x, remove Zone.js, and enable zoneless change detection in the demo app. - Replace Karma/Jasmine test builder configuration with
@angular/build:unit-test+runner: vitest, and update test typings/imports accordingly. - Migrate component state to signals and adapt template bindings where needed.
Reviewed changes
Copilot reviewed 12 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.spec.json | Switch spec typings from Jasmine to Vitest globals. |
| tsconfig.json | Adjust Angular compiler options for the Angular 22 upgrade. |
| src/app/app.config.ts | Enable zoneless change detection for the demo app. |
| src/app/app.component.ts | Migrate demo state (open/spin/direction) to signals. |
| src/app/app.component.spec.ts | Update unit test imports to Vitest. |
| src/app/app.component.html | Update bindings to consume signals (e.g., direction() / spin()). |
| projects/fab-speed-dial/tsconfig.spec.json | Update library spec TS config in support of Vitest. |
| projects/fab-speed-dial/src/lib/fab-speed-dial.ts | Update library internals to signals/linked signals and signal-driven template control flow. |
| projects/fab-speed-dial/src/lib/fab-speed-dial.spec.ts | Update library tests for signals + Vitest spies. |
| projects/fab-speed-dial/package.json | Bump Angular peer dependency range to ^22.1. |
| package.json | Upgrade Angular/tooling deps; add Vitest/jsdom; remove Karma/Jasmine/Zone.js deps. |
| angular.json | Switch test targets to @angular/build:unit-test using Vitest runner; remove Zone.js polyfills. |
| .github/workflows/main.yml | Update CI test invocation to match the new test runner setup. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
39
to
+41
| <mat-slide-toggle [(ngModel)]="open" (click)="stopPropagation($event)">Open</mat-slide-toggle> | ||
| <eco-fab-speed-dial [direction]="direction" [(open)]="open"> | ||
| <eco-fab-speed-dial-trigger [spin]="spin"> | ||
| <eco-fab-speed-dial [direction]="direction()" [(open)]="open"> | ||
| <eco-fab-speed-dial-trigger [spin]="spin()"> |
Comment on lines
14
to
20
| const fixture = TestBed.createComponent(TestAppComponent); | ||
|
|
||
| const testComponent = fixture.debugElement.componentInstance; | ||
| const speedDialDebugElement = fixture.debugElement.query(By.css('eco-fab-speed-dial')); | ||
|
|
||
| fixture.detectChanges(); | ||
| await fixture.whenStable(); | ||
| expect(speedDialDebugElement.nativeElement.classList.contains('eco-up')).toBeTruthy(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.