Skip to content

Use CCPP-framework provided constituent lookup methond - #560

Open
nusbaume wants to merge 2 commits into
ESCOMP:developmentfrom
nusbaume:remove_const_utils
Open

nusbaume wants to merge 2 commits into
ESCOMP:developmentfrom
nusbaume:remove_const_utils

Conversation

@nusbaume

@nusbaume nusbaume commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

Tag name (required for release branches):
Originator(s): nusbaume
AI tools used (if applicable; please also add the "AI-generated code" label to the PR):
What: Claude Opus-5.5
How: Claude implement the actual code changes based off my requests.

Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):

This PR replaces the use of the atmospheric_physics provided ccpp_const_get_idx with the CCPP-framework provided ccpp_constituent_index. The few places in CAM-SIMA where the constituent needs to be looked-up before the constituents object has been locked are now done via simple standard-name looping methods.

Describe any changes made to build system: N/A

Describe any changes made to the namelist: N/A

List any changes to the defaults for the input datasets (e.g. boundary datasets): N/A

List all files eliminated and why: N/A

List all files added and what they do: N/A

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)

M       .gitmodules
M       src/physics/ncar_ccpp
  - Bring in new atmospheric_physics tag with 'ccpp_const_get_idx' removed.

M       src/control/cam_comp.F90
M       src/data/air_composition.F90
  - Replace use of 'const_get_index' with local constituents loop,
     as the code is executing before the constituents object is locked.

M       src/physics/utils/cam_constituents.F90
M       src/physics/utils/musica_ccpp_dependencies.F90
  - Replace use of 'const_get_index' with CCPP-framework provided 'ccpp_constituent_index'.

If there are new failures (compared to the test/existing-test-failures.txt file),
have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?

derecho/intel/aux_sima:

derecho/gnu/aux_sima:

derecho/nvhpc/aux_sima (test is run via Github workflow. Only run the test manually if we need to save new baselines):

If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:

CAM-SIMA date used for the baseline comparison tests if different than latest:

@nusbaume
nusbaume deployed to CI-tests-on-CIRRUS October 1, 2026 17:20 — with GitHub Actions Active
@nusbaume nusbaume self-assigned this Oct 1, 2026
@nusbaume nusbaume added enhancement New feature or request AI-generated code labels Oct 1, 2026
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@nusbaume
nusbaume deployed to CI-tests-on-CIRRUS October 2, 2026 15:46 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI-generated code enhancement New feature or request

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant