sima0_22_000: CCPPize conv_water_4rad, cloud_water_paths - #531
Merged
Merged
Conversation
added 4 commits
July 22, 2026 14:55
Assisted-by: claude-fable:5 Add registry entries for the cloud_water physics suite Snapshot-readable inputs (REI, CONCLD, QSOUT, QGOUT), the grid-mean total cloud liquid/ice outputs of convective_cloud_water, and the one_mom_clouds flag (hardcoded .false.: one-moment RK microphysics is not a supported CAM-SIMA configuration; revisit if an RK+RRTMGP config arrives). CONCLD/QSOUT/QGOUT serve the follow-on cloud_water_paths port. Add outfrq_cloud_water_derecho test for the cloud_water physics suite FPHYStest SMS_Ln2 (aux_sima, derecho gnu) running suite_cloud_water from the CAM cloud_diagnostics_calc snapshot with ncdata_check, and writing the 12 CAM conv_water history fields from convective_cloud_water_diagnostics as an every-step REAL64 h1 baseline. Update ncar_ccpp to hplin/conv_water development head. Temporary hash pin for testing; replace with the atmos_phys tag containing the cloud_water suite before merge.
jimmielin
temporarily deployed
to
CI-tests-on-CIRRUS
July 28, 2026 14:43 — with
GitHub Actions
Inactive
jimmielin
had a problem deploying
to
CI-tests-on-CIRRUS
September 1, 2026 04:16 — with
GitHub Actions
Error
Collaborator
Author
|
A note that ideally #517 is merged in before this one, otherwise the |
nusbaume
reviewed
Sep 19, 2026
nusbaume
left a comment
Collaborator
There was a problem hiding this comment.
Just adding a note that I will approve this PR once ESCOMP/atmospheric_physics#447 has been merged and brought in as a submodule update.
nusbaume
approved these changes
Sep 22, 2026
jimmielin
requested a deployment
to
CI-tests-on-CIRRUS
September 28, 2026 14:47 — with
GitHub Actions
Waiting
jimmielin
pushed a commit
to jimmielin/CAM-SIMA
that referenced
this pull request
Oct 1, 2026
Brings in conv_water_4rad/cloud_water_paths (ESCOMP#531), ncdata_check_exclude (ESCOMP#517), the IC-read set-before-use skip (ESCOMP#547), misc code fixes (ESCOMP#507) and the atmos_phys0_29_001 pin. Conflict resolution: - ncdata_check_exclude (namelist definition, string_core_utils, phys_comp, physics_data) and write_init_files set-before-use: take the landed upstream versions; drop the branch's duplicate exclusion declarations. - registry.xml: keep the MAM wetdep/drydep/concld_old entries alongside the conv_water entries; drop the branch's duplicate icwmrsh. - write_init_files samples regenerated with the merged generator. Assisted-by: claude-opus:5.5
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag name (required for release branches): sima0_22_000
Originator(s): @jimmielin co-authored with @nusbaume
AI tools used (if applicable; please also add the "AI-generated code" label to the PR):
What:
How:
Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):
Describe any changes made to build system: N/A
Describe any changes made to the namelist: N/A
List any changes to the defaults for the input datasets (e.g. boundary datasets):
List all files eliminated and why:
List all files added and what they do:
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>)If there are new failures (compared to the
test/existing-test-failures.txtfile),have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?
derecho/intel/aux_sima:
derecho/gnu/aux_sima:
derecho/nvhpc/aux_sima (test is run via Github workflow. Only run the test manually if we need to save new baselines): All PASS
If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:
CAM-SIMA date used for the baseline comparison tests if different than latest: