Add optical scaling for logos and improve badge logo handling - #150
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request significantly improves the rendering and consistency of repository and owner logos in provenance badges. The main focus is on ensuring that all logos appear at a visually consistent size, regardless of their original aspect ratio or canvas padding. This is achieved by introducing an "optical size correction" (
logoScale) for each logo, updating the badge rendering logic, and adding comprehensive tests to enforce these constraints.Logo scaling and provenance badge improvements:
logoScaleproperty to theRepoIdentityand associated logo entry types, and populated all repository and owner logos with measured scale values to ensure consistent optical sizing across the badge strip. [1] [2]LogoImgand badge rendering logic inRepoProvenance.tsxto apply thelogoScaletransform, ensuring that all logos are visually balanced and clipped appropriately within a fixed-size slot. [1] [2] [3]Badgecomponent for both owners and repositories, removing the oldOwnerBadgeandWideLogocomponents. [1] [2]Data and configuration updates:
logoScalefor each.repoProvenance.tsto explain the rationale and measurement method forlogoScale. [1] [2]Testing and validation:
logoScaleand that all scale values are within the expected measured range, preventing visual regressions.These changes collectively ensure that provenance badges look professional and consistent, regardless of the source or format of the logo images.