Implement sidebar toggle and enhance file preview handling - #142
Merged
Merged
Conversation
ritwikshanker
force-pushed
the
feature/mobile-ui
branch
from
August 14, 2026 13:54
eb8ad83 to
4f41059
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a significant security improvement to the file preview proxy by replacing the in-memory allowlist with signed preview URLs, ensuring that only URLs generated by the server can be used for previews. It also improves error handling for expired or invalid preview links, enhances placeholder handling for the search input on small screens, and fixes some UI responsiveness issues.
File preview security and error handling:
PREVIEWABLE_URLSallowlist with a stateless signature-based system for preview URLs. The server now signs each file download URL it emits with a secret, and the preview proxy verifies this signature before allowing access, preventing request forgery and improving security for scaled deployments. (server.ts,docker-compose.yml,src/lib/coordinatorApi.ts,src/components/dataplayer/FilePreviewModal.tsx) [1] [2] [3] [4] [5] [6] [7] [8]src/components/dataplayer/FilePreviewModal.tsx,src/lib/coordinatorApi.ts) [1] [2] [3] [4] [5]API and backend robustness:
server.ts) [1] [2] [3]content-typeheaders from upstream sources, ensuring the correct media type is set for file previews. (server.ts)Frontend UI/UX improvements:
useMediaQueryReact hook and updates the search input to use shorter placeholders on narrow screens, improving usability on mobile devices. (src/hooks/useMediaQuery.ts,src/components/SearchInput.tsx) [1] [2] [3] [4] [5] [6]src/components/ConversationSidebarItem.tsx,src/components/SearchFeedback.tsx) [1] [2]