Skip to content

Updated RO-Crate metadata for Galaxy workflow. - #100

Draft
recap wants to merge 2 commits into
EOSC-Data-Commons:masterfrom
recap:fix/update_galaxy_crate
Draft

Updated RO-Crate metadata for Galaxy workflow.#100
recap wants to merge 2 commits into
EOSC-Data-Commons:masterfrom
recap:fix/update_galaxy_crate

Conversation

@recap

@recap recap commented Apr 23, 2026

Copy link
Copy Markdown
Collaborator

Updates:

  • License is resolvable URI
  • Misuse of # for Data Entities; # is for files that do not exist yet like outputs
  • url -> contentUrl
  • Correct MIME types
  • Remove runsOn does not seem to be part of RO-Crate which might break interoperability?
  • Service incorrectly in hasPart; hasPart is for Data Entities; Service is contextual.

…hema version and minor formatting adjustments.
@andrejcermak

Copy link
Copy Markdown
Collaborator

Could you please reformat the json so it is apparent what the removed and added lines are?

}
},
{
"@id": "#destination",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it is a minor problem, but this element is "orphaned"; it is not linked with any other entity.
This is why, in the previous version, we had the "runsOn" field; maybe it wasn't the best solution, but it links the "destination" with the main entity.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. It is not a minor issue. We need to think how to link it while still being compliant and interoperable.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One way is to use softwareRequirements from the spec for ComputationalWorkflow which seems to allow for runtime environments which would be something like:

{
  "@id": "workflow/galaxy_workflow.ga",
  "@type": ["File", "SoftwareSourceCode", "ComputationalWorkflow"],
  "name": "Example Galaxy workflow",
  "description": "Example Galaxy workflow reversing a text file.",
  "programmingLanguage": {
    "@id": "https://w3id.org/workflowhub/workflow-ro-crate#galaxy"
  },
  "encodingFormat": "application/json",
  "contentUrl": "https://dockstore.org/api/ga4gh/trs/v2/tools/%23workflow%2Fgithub.com%2Flaitanawe%2Fismb2024%2Fgalaxy_example/versions/main/PLAIN_GALAXY/descriptor//Galaxy-Workflow-reverse_file_galaxy_workflow.ga",
  "softwareRequirements": {
    "@id": "#destination"
  }
}

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrejcermak For semantic diff you can use json diff tools like https://jsoncompare.com/

@andrejcermak

Copy link
Copy Markdown
Collaborator

hi @recap I am currently working on a major change for the whole ROCrate approach, including compliance with the ROCrate standards. I will include your comments from the top of this thread and we can then discuss it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants