Improve the fetcher

[enolfc]

Summary

The fetcher should not remove existing data if it cannot retrieve new data from the object store.
This change just makes the fetcher exit early in case of error and avoids removing all previously available data.
It also logs the cron job output to the syslog for tracking issues easily

---

Related issue :

[github-actions]

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Plan 📖success

Show Plan

terraform
Acquiring state lock. This may take a few moments...
openstack_compute_secgroup_v2.motley-cloud-info-api: Refreshing state... [id=e3b8d8bc-085f-4f94-b47a-d60823a51919]
openstack_compute_secgroup_v2.secgroup: Refreshing state... [id=fdb33a92-b33a-4116-82f6-806e99b55269]
data.openstack_images_image_v2.egi-docker: Reading...
openstack_networking_floatingip_v2.fip: Refreshing state... [id=c9748d9d-b5db-4a45-98c3-42bf7d990d96]
data.openstack_images_image_v2.egi-docker: Read complete after 2s [id=e054ef3c-37c5-49a8-904a-1111720903bc]
openstack_compute_instance_v2.cloud-info-api: Refreshing state... [id=3e3203e4-3457-4f30-9f4b-25ecf146264b]
openstack_compute_floatingip_associate_v2.fip: Refreshing state... [id=147.213.76.180/3e3203e4-3457-4f30-9f4b-25ecf146264b/]

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

Warning: Argument is deprecated

  with provider["registry.terraform.io/terraform-provider-openstack/openstack"],
  on clouds.tf line 12, in provider "openstack":
  12: provider "openstack" {

Users not using loadbalancer resources can ignore this message. Support for
neutron-lbaas will be removed on next major release. Octavia will be the only
supported method for loadbalancer resources. Users using octavia will have to
remove 'use_octavia' option from the provider configuration block. Users
using neutron-lbaas will have to migrate/upgrade to octavia.

(and one more similar warning elsewhere)

Warning: Deprecated Resource

  with openstack_compute_secgroup_v2.secgroup,
  on main.tf line 12, in resource "openstack_compute_secgroup_v2" "secgroup":
  12: resource "openstack_compute_secgroup_v2" "secgroup" {

use openstack_networking_secgroup_v2 resource instead

(and 5 more similar warnings elsewhere)
Releasing state lock. This may take a few moments...

Pusher: @enolfc, Action: pull_request

[github-actions]

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Plan 📖success

Show Plan

terraform
Acquiring state lock. This may take a few moments...
openstack_networking_floatingip_v2.fip: Refreshing state... [id=c9748d9d-b5db-4a45-98c3-42bf7d990d96]
data.openstack_images_image_v2.egi-docker: Reading...
openstack_compute_secgroup_v2.motley-cloud-info-api: Refreshing state... [id=e3b8d8bc-085f-4f94-b47a-d60823a51919]
openstack_compute_secgroup_v2.secgroup: Refreshing state... [id=fdb33a92-b33a-4116-82f6-806e99b55269]
data.openstack_images_image_v2.egi-docker: Read complete after 2s [id=e054ef3c-37c5-49a8-904a-1111720903bc]
openstack_compute_instance_v2.cloud-info-api: Refreshing state... [id=3e3203e4-3457-4f30-9f4b-25ecf146264b]
openstack_compute_floatingip_associate_v2.fip: Refreshing state... [id=147.213.76.180/3e3203e4-3457-4f30-9f4b-25ecf146264b/]

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

Warning: Argument is deprecated

  with provider["registry.terraform.io/terraform-provider-openstack/openstack"],
  on clouds.tf line 12, in provider "openstack":
  12: provider "openstack" {

Users not using loadbalancer resources can ignore this message. Support for
neutron-lbaas will be removed on next major release. Octavia will be the only
supported method for loadbalancer resources. Users using octavia will have to
remove 'use_octavia' option from the provider configuration block. Users
using neutron-lbaas will have to migrate/upgrade to octavia.

(and one more similar warning elsewhere)

Warning: Deprecated Resource

  with openstack_compute_secgroup_v2.secgroup,
  on main.tf line 12, in resource "openstack_compute_secgroup_v2" "secgroup":
  12: resource "openstack_compute_secgroup_v2" "secgroup" {

use openstack_networking_secgroup_v2 resource instead

(and 5 more similar warnings elsewhere)
Releasing state lock. This may take a few moments...

Pusher: @enolfc, Action: pull_request