Feat: Offline hours and time to join customisations - #405
Conversation
DavidArthurCole
left a comment
DavidArthurCole
left a comment
There was a problem hiding this comment.
Because this PS is reliant, the underlying logic has some issues;
Comment at ProcessCoop.cs:538-540 says removal frees the spot for /findcoopforuser, but rn it doesn't
ContractCommandsSlash.cs:126-127, existingCoop has no !Removed condition, so kicked users read as AlreadyAssigned to the coop they got kicked from, which would break /findcoopforuser and Find Coop Spot.
CoopAssignmentLookup.cs:53-59 + fallback at ContractCommandsSlash.cs:701-710 have the same gap. Find My Coop button still points kicked users at the coop they got removed from. Should probably sweep the rest of the UserCoopXrefs reads for this too, UserStatusCommands.cs:179 seems to be one as well.
| migrationBuilder.AddColumn<int>( | ||
| name: "OfflineDemeritHours", | ||
| table: "Guilds", | ||
| type: "integer", | ||
| nullable: false, | ||
| defaultValue: 30); | ||
| } |
There was a problem hiding this comment.
30h default applies to every guild with BG on - might need to confirm with shareholders
2 participants
Note: JoinWarning12h and JoinWarning24h no longer reflect the actual duration but I'm leaving them as is since it doesnt buy us any function changing them.