Chore: Data Attribute for (Coop/Contract)-Dependent Commands - #378
Open
DavidArthurCole wants to merge 4 commits into
Open
Chore: Data Attribute for (Coop/Contract)-Dependent Commands#378DavidArthurCole wants to merge 4 commits into
DavidArthurCole wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #377
There were (are) lots of commands that "depend on" being run in a Contract, or Coop channel, most of which were doing the same shape of lookup/reject.
This PR adds a new Attribute, that "pre-defines" what the interaction is "dependent on," and defers the lookup of it to the module base, instead of letting each command separately implement logic for it.