Support ne256 in tc_analysis - #879
Draft
chengzhuzhang wants to merge 1 commit into
Draft
chengzhuzhang wants to merge 1 commit into
chengzhuzhang wants to merge 1 commit into
Conversation
Add the ne256 warm-core search radius (0.15 degrees) recommended in #855, list the supported resolutions in the error messages and docs, and correct the description of the warm-core criterion. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
@kaizhangpnl hi, Kai. I quickly created this PR based on your recommendation. Could you provide some ne256 output that I can test this with? Thank you! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #855.
Summary
tc_analysischose the DetectNodes warm-core search radius only for ne30 (1.0°) and ne120 (0.30°), and any other resolution failed withERROR (13). This PR adds ne256 with 0.15°, the value @kaizhangpnl recommends in #855. The existing ne30 and ne120 values already match his.Changes
zppy/templates/tc_analysis.bashres == 256case (temp_threshold_radius=0.15).input_griderror describes theneXpg2/neXnp4format.temp_threshold_radiusis theminmaxdistfield of--closedcontourcmd. DetectNodes first finds the maximum of the 200/500 hPa average temperature within that distance of the SLP minimum (about one grid spacing, so it depends on resolution). The 0.6 K decrease within 4° is then tested from that maximum, not from the SLP minimum as the old comment said.zppy/defaults/default.ini,docs/source/user_guide/tasks/tc_analysis.rst: addne256pg2to theinput_gridexamples and list the supported resolutions.tests/test_tc_analysis_resolution.py(new): renders the template and runs its resolution block in bash. It checks the radius for 30, 120 and 256, and checks that an unsupported value exits with status 13.No other ne256-specific changes were needed. Mesh generation (
GenerateCSMesh --res, plusGenerateVolumetricMeshfor pg2) and theinput_gridparsing already accept anyneX.Not included
The second part of #855, the resolution-dependent NodeFileEditor radial wind profile bins, doesn't apply to zppy. zppy's
tc_analysisruns DetectNodes, StitchNodes and HistogramNodes, followed by the AEW steps, and doesn't compute radial profiles.Testing
main, the ne256 and error-message tests fail.ne256pg2_ne256pg2.F2010xx-ZM-CICE.260306.splitform_TMSoff_Recipe2_updated) has 3-hourly native-grid output, but it lacksT_mid_at_200hPa,T_mid_at_500hPa,U/V_at_model_botandU/V_at_850hPa. This PR stays a draft until the change can be run on ne256 output that has thetc_vars.🤖 Generated with Claude Code