Update 2 of Adds new ocean to ice coupling fields for frazil ice formation - #558

Closed

njeffery wants to merge 5043 commits into

E3SM-Project:masterfrom

njeffery:njeffery/frazil-coupling

This pull request is big! We're only showing the most recent 250 commits

Commits on Jul 31, 2026

EAMxx: timestamp handling in setup_file for average/min/max output types
mahf708
committed
9b93458
Update METIS/PARMETIS paths for polaris v1.1.0
andrewdnolan
committed
e3bbc84
Add unit tests for monthly storage with AVERAGE/MIN/MAX averaging types
Copilot
authored
a686e01
Exchange halos after vertical mixing
andrewdnolan
committed
c05ffb8
Adds missing namelist item read_hdd_cdd
evasinha-pnnl
committed
8fffbdc
EAMxx: remove unneeded comments by copilot
mahf708
authored
2f1cd52
Make RungeKutta4 timestepper default for all meshes
andrewdnolan
committed
03e986a
Fix environment variables for Aurora
sbrus89
committed
b340052
Merge branch 'mahf708/eamxx/fix-organized-storage-specifier' (PR #8592)
bartgol
authored
3302398
EAMxx: fix racy multi-rank writes to shared HOMME log file

mt5555
and
Copilot
committed
6b8d505

Commits on Aug 1, 2026

Merge pull request #470 from andrewdnolan/omega/coupled-driver
sbrus89
authored
1834327
Correct vertex ordering requirement in MPAS mesh spec

xylar
and
claude
committed
0b0c4c6

Commits on Aug 2, 2026

Check cross-type reads of non-distributed variables in IOTest

xylar
and
claude
committed
dce1b17
Convert data types when reading non-distributed variables

xylar
and
claude
committed
0396958
Add a single-precision VertCoord test

xylar
and
claude
committed
2128075

Commits on Aug 3, 2026

Update C++ tensorVisc after dss_hvtensor runs

mt5555
and
Copilot
committed
9cda8e9
Merge branch 'odiazib/eamxx/moab_flight' into master (PR #8591)
jgfouca
committed
c99a8f0
update mam4xx.
odiazib
committed
328ef3b
add missing ZM temperature tendency
whannah1
committed
e6fd0e0
Remove unused deprecated py import in ww3 buildlib_cmake
jgfouca
committed
367dbf9
initial port to vista
ndkeen
committed
05ccee4
Merge branch 'jgfouca/update_ww3_buildib' into master (PR #8603)
jgfouca
committed
493e32b
Merge pull request #491 from xylar/omega/fix-vert-coord-single-precision
sbrus89
authored
061d0ab

Commits on Aug 4, 2026

Merge branch 'jonbob/testing/add-v32-tests' (PR #8442)
jonbob
committed
63c3495
Merge branch 'whannah/eamxx/add-missing-zm-detr-term' (PR #8599)
tcclevenger
authored
5bace1f
Merge branch 'mt5555/eamxx/fix-homme-log-race' (PR #8595)
tcclevenger
authored
86d0c36
Add default layouts for TL319_IcoswISC30E3r5_wQU225Icos30E3r5 grid
jonbob
committed
f222850
Switch python linting from isort and flake8 to ruff

xylar
and
claude
committed
70879b8
Apply ruff formatting to Omega's python code

xylar
and
claude
committed
d11a68f
Merge branch 'PAESCAL-SciDAC5:eam_guardrails' (PR #8537)
wlin7
committed
3ebc8de
Merge pull request #477 from mwarusz/omega/fix-auxstate-timestep
sbrus89
authored
c83fe0d

Commits on Aug 5, 2026

Add flake8-errmsg

xylar
and
andrewdnolan
authored
242937f
Fix flake8-errmsg violations in Omega's CIME scripts

xylar
and
claude
committed
95110eb
Merge pull request #498 from xylar/omega/linting/switch-to-ruff
xylar
authored
da36337
Modified run-script, baseline file names, & giac pointer
evasinha-pnnl
committed
6a247a3
Merge branch E3SM-Project/ndk/machinefiles/add-machine-vista (PR #8604)
ndkeen
authored
d4092a3
Remove CXX standarded being set in EAMxx
tcclevenger
committed
9dc1ddb
Remove references to C++17 from machine files in homme/cmake and cime_config
tcclevenger
committed
5df1be2
Remove default cxx standard from buildlib.ekat
tcclevenger
committed
120def3
Only set cxx standard in homme machine files
tcclevenger
committed
3978fad
Add missing EXCLUDE_MAIN_CPP from p3 test
tcclevenger
committed
705c5b7

Commits on Aug 6, 2026

Add missing EXCLUDE_MAIN_CPP from p3 test
tcclevenger
committed
8942cc4
Merge branch 'tcclevenger/fix_p3_test_fail' (PR #8611)
tcclevenger
authored
23311b9
Add 3D calculation of shear production of turbulence to EAMxx

Peter Bogenschutz
authored and
tcclevenger
committed
4f9b99b
Give each Omega unit test its own log file

xylar
and
claude
committed
4715165
Document Omega log file naming

xylar
and
claude
committed
fb71bc4
Move LogFileStream out of Logging.h

xylar
and
claude
committed
3c73b80
Temporarily disable call to new shear property tests.

Peter Bogenschutz
authored and
tcclevenger
committed
825a237
Merge branch 'tcclevenger/update_to_cpp20' (PR #8559)
tcclevenger
authored
66395db
Merge branch 'jonbob/grids/add-ww3-layouts' (PR #8609)
jonbob
committed
33c69be
Merge branch 'odiazib/eamxx/photo-table-fix' (PR #8579)
jeff-cohere
committed
a6f5184

Commits on Aug 7, 2026

Fix ZM restart tests
whannah1
authored
de49918
Fix a bug in field registration of ProvPseudoThickness
hyungyukang
committed
9d54e56
Merge pull request #488 from andrewdnolan/omega/bfb-restart-fixes
sbrus89
authored
3cd7cdd
Merge branch 'master-tensorvisc-fix' (PR #8597)
tcclevenger
authored
538e092
Merge pull request #492 from xylar/omega/fix-per-ctest-logs
sbrus89
authored
2e5ecd7
Simplify creation of Tendencies
mwarusz
committed
9cf1234
Update Tendencies documentation to reflect new create API

Copilot
and
mwarusz
committed
edc1c7f
Add reconstruction stencil arrays to Decomp

andrewdnolan
and
Copilot
committed
4fcffac
Conditionally read Weights in HorzMesh
andrewdnolan
committed
88777bc
Add VectorReconstructOnCell opeator and unit test
andrewdnolan
committed
6c90ead
Update documentation
andrewdnolan
committed
1a7edc1
Update mesh paths
andrewdnolan
committed
7f6ae6b
Apply suggestions from code review

committed
338b8f6
Fix variable names and rename Reconstruct to Recon
andrewdnolan
committed
edcccae
Use new names when reading from mesh
andrewdnolan
committed
d1121a4
Add clarifying comment to docs about MaxEdge2
andrewdnolan
committed
d6ca1f0
Update mesh paths
andrewdnolan
committed
085d04c

Commits on Aug 8, 2026

Add TEOS-10 first derivatives of specific volume

xylar
and
claude
committed
e47c867
Add specific volume derivatives for linear and constant EOS

xylar
and
claude
committed
5994ce9
Add Eos::computeSpecVolAndDerivs

xylar
and
claude
committed
2142df1
Add unit tests for TEOS-10 specific volume derivatives

xylar
and
claude
committed
41eed23
Compute Brunt-Vaisala coefficients from the specific volume derivatives

xylar
and
claude
committed
4c1fe99
Document specific volume derivatives in the EOS guides

xylar
and
claude
committed
4c10fdb
Distinguish point-wise and chunk-wise derivative calls by name
xylar
committed
cb0b333
Explain when the specific volume derivatives are computed
xylar
committed
7013542
Say why alpha and beta cannot reuse the stored derivatives
xylar
committed
127f072
Distinguish the two GSW-C based derivative tests
xylar
committed
8d4e38b
Correct which calls need the specific volume derivatives
xylar
committed
5bcbefc
Remove vertical chunking from the equation of state

xylar
and
claude
committed
638c744
Rename calcSpecVolAndDerivsInChunk to OnCells

xylar
and
claude
committed
fa2ffdf

Commits on Aug 9, 2026

Merge branch 'master' into bogensch/eamxx/turb_3d_shear_production
bogensch
authored
49f1ce7

Commits on Aug 10, 2026

Check for null pointers in create and init methods

mwarusz
and
Copilot
committed
5503df1
Initialize VertAdv in a few tests
mwarusz
committed
1e4bf1b
Update ocean fraction calculation using mask
whannah1
authored
28849b6

Commits on Aug 11, 2026

Commits on Aug 12, 2026

This includes updates from mam4xx, particularly the photolysis tables and the code reorganization of the get_e3sm_parameters routine.
odiazib
committed
f21eeac
Add missing halo exchanges
andrewdnolan
committed
960019f
Apply suggestions from code review

andrewdnolan
and
hyungyukang
committed
b879387
Switch JRA1p4-2018 to JRA1p5 for C-case
andrewdnolan
committed
70bdb7f
Add testmods for Omega
andrewdnolan
committed
46c14fb
Add missing hist file extension entry
andrewdnolan
committed
8906cf6
Add e3sm_omega_developer test suite
andrewdnolan
committed
08944ce
Merge pull request #503 from mwarusz/omega/validate-ptrs
sbrus89
authored
c2b0bf8
Comment out PEM, add SMS tests in their stead
andrewdnolan
committed
cd9e1e1
Refactor buildnml to support external configs
andrewdnolan
committed
d5c9ec2
Add external type module
andrewdnolan
committed
b79e7b5
Make clear coupled overrides is required
andrewdnolan
committed
21fa4e6
Move validation into it's own module
andrewdnolan
committed
4f3632f
Add validation of config_overrides file strcutre
andrewdnolan
committed
af1a6ab
Validate parameter overrides against Default.yml
andrewdnolan
committed
eb8298a
Ensure KNOWN_STREAMS stays in sync with Default.yml
andrewdnolan
committed
ff89814
Add validation cli entry point and CI workflow
andrewdnolan
committed
c16ee75
Fail fast when YAML file has duplicate entries
andrewdnolan
committed
bbcc852
Add support for user_nl_omega
andrewdnolan
committed
2c65181
Add unit tests and CI job for running them

andrewdnolan
and
Copilot
committed
8739599
Add brief documentation in the form of READMEs
andrewdnolan
committed
9c81645
Add documentaion within docs directory
andrewdnolan
committed
c49e75e
Apply suggestions from code review

andrewdnolan
and
Copilot
committed
54b27ae
Update comments follwing code review
andrewdnolan
committed
ac22f70
Remove `KNOWN_STREAMS` and associated validation
andrewdnolan
committed
03d0d55
Apply ruff formatting
andrewdnolan
committed
fab1c33
Fix turning on sfc stress tendency in coupled mode
andrewdnolan
committed
84c4aac
Update mesh paths
andrewdnolan
committed
11b8a8e
Merge branch 'xylar/mpas-framework/fix-standalone-intel-cray-preprocessing' (PR #8574)
jonbob
committed
72ee057
Merge branch 'bogensch/eamxx/turb_3d_shear_production' (PR #8392)
tcclevenger
authored
c8f59e1
Merge pull request #502 from hyungyukang/omega/fix-aux-state-write
sbrus89
authored
e4edce6

Commits on Aug 13, 2026

Merge pull request #490 from andrewdnolan/omega/forward-backward-halo
sbrus89
authored
607dc7c
Merge branch 'rfiorella/eamxx/water-isotope-infra-001-register-processes' (PR #8505)
bartgol
authored
5cd504d
Merge branch 'odiazib/eamxx/update-mam4xx' (PR #8620)
jeff-cohere
committed
a899004
Add MPI_Barrier before MPI_Finalize
mwarusz
committed
fc80015
Merge pull request #485 from xylar/omega/add-teos10-alpha-derivatives
sbrus89
authored
7d4d8bf
EAMxx: Using DataInterpolation class for surface emissions.
odiazib
committed
b0a6c47
Updating nc files.
odiazib
committed
1ef9351
Remove interpolated fields from the field manager.
odiazib
committed
a347cc4
Simplifying the code through field operations.
odiazib
committed
d1f57f7
Removing unnecessary work view.
odiazib
committed
ebcbf04

Commits on Aug 14, 2026

Limit implicit vertical mixing to owned cells and edges
hyungyukang
committed
6b4ae1c
Address reviewer comments
hyungyukang
committed
d307685
Changing the CACHE type for MAM4XX_PRECISION from BOOL to STRING.
jeff-cohere
committed
f3ec020
Add IOP create_horiz_remappers support to the DataInterpolation class to avoid duplicating the logic in multiple places.
odiazib
committed
5931df2
Removing duplicate code.
odiazib
committed
b18f962
Changes the error check because the field may include data for ghost elements
bishtgautam
committed
3f9661a
Initialize only the locally owned cells
bishtgautam
committed
c6c690d
Adds code to do MOAB-based halo exchange
bishtgautam
committed
a74c304
Adds code to initialize naturally vegetated ghost columns
bishtgautam
committed
95993dd
Perform halo exhcnage for soil properties
bishtgautam
committed
c94c8e6
Initialize ghost grid cells
bishtgautam
committed
06883da
Modifies computation of beg/end indices for ghost subgrid units
bishtgautam
committed
0c60672
Adds column-to-column connections when using MOAB
bishtgautam
committed
19fcbe5
elm: Improve MOAB halo exchange in SoilStateType and domainLateralMod
bishtgautam
committed
0b8b78d
Address review comments
bishtgautam
committed
c515548

Commits on Aug 16, 2026

tensor laplace option
mt5555
committed
6d4d45a
also DSS and linearlize the new tensorVisc_2
mt5555
committed
70e0faa
port tensor Laplace operator to EAMxx (via claude)
mt5555
committed
df8b97f
fix(eamxx): expose laplace_scaling in ctl_nl namelist for EAMxx

mt5555
and
Copilot
committed
3559f8a
add ability to set new laplace_scalings in EAM
mt5555
committed
b889d04
Pass tensorVisc_2 through preqx_kokkos interop

mt5555
and
Copilot
committed
5f7d955
fix(homme): repair unit test SIGSEGVs in dirk_ut and gllfvremap_ut

mt5555
and
Copilot
committed
4ab9e4e

Commits on Aug 17, 2026

Merge branch 'whannah/eamxx/fix-ZM-restart' (PR #8616)
tcclevenger
authored
fe750f5
fix(homme): init nu_scale_top_ilev_pack_lim for tom_sponge_start>0

mt5555
and
Copilot
committed
0f13102
Removing the create_horiz_remappers(const Real iop_lat, const Real iop_lon) method
odiazib
committed
e0b3773
Merge pull request #505 from hyungyukang/omega/limit-vmix-loop
sbrus89
authored
a8d838b
Merge pull request #494 from andrewdnolan/omega/buildnml-build-out
sbrus89
authored
2ef2b57
add the capability in SPC to read a list of gas species
mingxuanwupnnl
committed
e6565ef
Call CHECK_ERROR_ABORT before MPI_Finalize
mwarusz
committed
71dd287
port forcing tendencies (thickness and tracers) + update doc, yml

alicebarthel
authored and
katsmith133
committed
ec56559
added the enthalpy of mass fluxes; CtFrz has public interface

alicebarthel
authored and
katsmith133
committed
4956cf8
added a test for thermo forcing tendencies

alicebarthel
authored and
katsmith133
committed
72f00b3
made mass enthalpy flux dependent on thickness flag - under discussion

alicebarthel
authored and
katsmith133
committed
45c792f
draft a non-teos10 CtFrz in comments - WIP

alicebarthel
authored and
katsmith133
committed
36c9a37
updated the documentation

alicebarthel
authored and
katsmith133
committed
9b87769
Revert "made mass enthalpy flux dependent on thickness flag - under discussion"

alicebarthel
authored and
katsmith133
committed
fae5a4a
updated the documentation

alicebarthel
authored and
katsmith133
committed
90f045e
correction to pressure units and ctest

alicebarthel
authored and
katsmith133
committed
1226b96
update due to fill values and review comments

alicebarthel
authored and
katsmith133
committed
db218ac
resolve memory issue on GPUs

alicebarthel
authored and
katsmith133
committed
965b549
inlines eos::calcPtFromCt in header with kokkos_function to fix gpu warning
katsmith133
committed
554a9ff
adds linear and constant eos options to thermal forcing
katsmith133
committed
0fd8e35
adds notes to docs and adds suggestions from review
katsmith133
committed
b5c586f
Adds reset of forcing fields if not in stream

vanroekel
authored and
katsmith133
committed
a739dfc
Update components/omega/doc/devGuide/Forcing.md

cbegeman
authored and
katsmith133
committed
14065fc
Fixup documentation

cbegeman
authored and
katsmith133
committed
fded0f4
remove SurfInsituTemp calcs

Katherine Smith
authored and
katsmith133
committed
9fa07ce
fixes GPU failures on frontier

Katherine Smith
authored and
katsmith133
committed
5bed059
Revert "fixes GPU failures on frontier"
katsmith133
committed
0864050
fixed GPU isssues on Frontier
katsmith133
committed
b35ff14
fixes omega_pr errors on Frontier
katsmith133
committed
c561101
changes assumptions about enthalpy calculation, per PR review comments
katsmith133
committed
e799907
added limiter and Evap Enthalpy to TendencyTerms

alicebarthel
authored and
katsmith133
committed
5772ba3
renamed latent to specify evap and updated the docs

alicebarthel
authored and
katsmith133
committed
d1212bc
added missing arguments

alicebarthel
authored and
katsmith133
committed
85cff87
adds non-teos option to limiter
katsmith133
committed
808185a
EAMxx: set compiler flags before parsing EKAT
bartgol
committed
cab1aab

Commits on Aug 18, 2026

Commits on Aug 19, 2026

Commits on Aug 20, 2026

Commits on Aug 21, 2026

Commits on Aug 24, 2026

Merge branch 'odiazib/eamxx/surface_emission_data_inter' (PR #8430)
jeff-cohere
committed
d403f4a

Commits on Aug 25, 2026

Merge remote-tracking branch 'e3sm/master' into HEAD
sbrus89
committed
26ee34e
Merge pull request #518 from mwarusz/omega/richardson-fix
sbrus89
authored
e7dc83d
Use nonunit diffusivities in tendency terms test
mwarusz
committed
2e3dc04
Remove vert chunking from most tendency terms
mwarusz
committed
53336f4
Remove vert chunking from aux vars
mwarusz
committed
40ad947
Add and use subviewUnmanaged
mwarusz
committed
a6e6ced
Fix double mult by EddyDiff2
mwarusz
committed
e56ac36
Fix vertical bounds in tracer flux divergence
mwarusz
committed
64a93e2
Allocate scratch for pseudo-thickness cell aux
mwarusz
committed
0409bdc
Improve LinearIdxWrapper to better hide implementation details
mwarusz
committed
939123d
Update kinetic energy computation in vert mixing
mwarusz
committed
5a36da2
Pass by value in subviewUnmanaged
mwarusz
committed
00f7a37

Commits on Aug 27, 2026

Commits on Sep 1, 2026

Merge pull request #461 from alicebarthel/omega/add-thermo-forcing
sbrus89
authored
ee6397a

Commits on Sep 2, 2026

add index_x2i_Fioo_frazils (frazil salt flux) to ice_comp_mct.F,mpassi_cpl_indices.F,seq_flds_mod.F90

erinethomas
authored and
darincomeau
committed
d13670a
Add additional frazil coupler fields.

karapeterson
authored and
darincomeau
committed
5b5624d
adding o2x_Fioo_frazilh/o2x_Fioo_frazils to mpaso

erinethomas
authored and
darincomeau
committed
6e47f96
Enable variable salinity coupling inputs for sea ice

proteanplanet
authored and
darincomeau
committed
b922415
Updating icepack submodule 9.2.26
darincomeau
committed
4d4ae66
Addition to allow E3SM configuations to build without OMEGA

jonbob
authored and
darincomeau
committed
f1c42f8
Add budgeting in mct coupler for new coupling fields.

karapeterson
authored and
darincomeau
committed
fe2f9ab
Fix bugs leading to build errors.

karapeterson
authored and
darincomeau
committed
e8facde
Adds omega-fluxes option for frazil coupling in sea ice

njeffery
authored and
darincomeau
committed
3830224
Update sea ice config checks

njeffery
authored and
darincomeau
committed
89971c0
Corrects update sea ice config options

njeffery
authored and
darincomeau
committed
357a174
Fixes salt flux units error

njeffery
authored and
darincomeau
committed
35dafdf
Make frazil energy consistent with the ocean energy change

njeffery
authored and
darincomeau
committed
86fd22f
fixed type introduced in last commit

njeffery
authored and
darincomeau
committed
3c91b8b
Corrections to ensure BFB

njeffery
authored and
darincomeau
committed
0114420
Clean up ocean frazil routine

njeffery
authored and
darincomeau
committed
cc98c44
corrects typo in frazil routine

njeffery
authored and
darincomeau
committed
db89f0c
Remove redundant newFrazilEnergy

njeffery
authored and
darincomeau
committed
32b6494
Added copilot suggestions

njeffery
authored and
darincomeau
committed
ea24e0f

Commits on Sep 15, 2026

Splits ocean coupling of freezemelt potential into frazil heat and melt
njeffery
committed
de59708

Commits on Sep 16, 2026

Clean up coupler diagnostics for frazil
njeffery
committed
9f736dc