add a teos-10 version of frazil formation+melt - #462
alicebarthel wants to merge 11 commits into
Conversation
|
@njeffery the key simplification that I have left in at this stage is that formation/melt is calculated based on the per-layer characteristics (i.e. would this layer freeze? --> adds to the frazil formed). The better way that we agreed to try is to mix the frazil (energy, mass, salt) first before assessing whether the layer would freeze. |
8615be8 to
d85d5d7
Compare
|
@njeffery, thanks for your feedback! I updated the code accordingly: massLimit on melt tendency, and refactoring the melt terms using a common factor |
|
@alicebarthel, can this be closed in favor of #466? |
|
@alicebarthel Should this be closed? |
|
closing this in favor of #466 which contains both the "fixed property" and the teos-10 versions of frazil. |
This draft PR is to provide a space to review/discuss the implementation of a new frazil code.
The frazil is meant to be thermodynamically consistent with the teos-10 ocean in omega.
We calculate the (cell, layer) tendencies and store 3 column-accumulated frazil fields that will be passed to the coupler.
For conservation, we keep track of pure (fresh) ice mass, brine water mass, and brine salt mass separately within the ocean to allow melt to be energetically-consistent.
I added a vertical conservation check and a vertical depth limit.
The tests currently rely on a verbose log that only work on CPU. This will be removed before merge/production.
The eos functions rely on the module, which require CPU. Later port of eos features will allow portability.
I haven't gotten to type up a clean omega frazil documentation yet, but the existing overleaf should be roughly in line with this implementation. Happy to discuss.
Checklist
pm-cpuhas passed, using the Polaris
e3sm_submodules/Omegabaseline-pfor both the baseline (Polarise3sm_submodules/Omega) and the PR build