[Test] 대시보드 집계 쿼리 수 검증 테스트 추가 - #345
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: DocGrid/docgrid/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
DashboardQueryService.getSummary()는 코드상 쿼리 9개(문서 3 + 작업 4 + Worker 1 + 검색 1)로세어지지만 이를 검증하는 테스트가 없었다. 지표를 추가하거나 조회 방식을 바꿀 때 쿼리 수가
조용히 늘어나도 알 수 없고, 이벤트 기반 push(#151)의 debounce 설계가 "1회 집계 = 쿼리 약 9개"라는
추정에 의존하고 있었다.
실제 PostgreSQL에서 Hibernate
Statistics로 측정한 결과 9개로 확인되어, 이를 회귀 테스트로 고정한다.✅ 변경 사항
DashboardQueryCountIntegrationTest추가getSummary()1회의 prepared statement 수가 정확히 9개인지 검증✅ 테스트 결과
DashboardQueryCountIntegrationTest: 1건 통과 (실제 PostgreSQL)dashboard패키지 전체: 24건 통과 (실패 0, 오류 0)📒 기타
closes #344
🤖 Generated with Claude Code
Summary by CodeRabbit