[shakourllahfashola-dev]

Closes #9

[drips-wave]

@shakourllahfashola-dev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

[github-actions]

@shakourllahfashola-dev This PR now has merge conflicts with main, most likely because #152 (feat(contract): payer cancellation window before the payee accepts) was just merged, so it can't be merged until it's rebased:

git fetch upstream            # upstream = https://github.com/DocForum/docforum-escrow.git
git rebase upstream/main
# resolve the conflicts, re-run the tests, then:
git push --force-with-lease

The usual culprits are shared docs like ROADMAP.md and ARCHITECTURE*.md. If the conflict is in the ROADMAP.md changelog, move your entry into a new file under changelog.d/ (see changelog.d/README.md) rather than resolving it in place, so it can't conflict again. CI re-runs when you push, and the needs-rebase label is removed automatically once the conflicts are resolved.

_{Automated message. It won't repeat unless the PR conflicts again after your next push.}

[afeezorobsco-cyber]

@shakourllahfashola-dev CI is failing on this branch against the latest main, so it can't be merged yet. The errors from the latest run:

Soroban contract (test + wasm build), Reproducible WASM across checkout paths, SDK bindings match contract WASM

error[E0425]: cannot find value `event_destination` in this scope
error[E0425]: cannot find value `escrow_id` in this scope
error[E0425]: cannot find value `payer` in this scope
error[E0425]: cannot find value `destination` in this scope
error[E0423]: expected value, found module `token`
error[E0425]: cannot find value `amount` in this scope
error[E0599]: no associated function or constant named `emit_lifecycle` found for struct `EscrowContract` in the current scope
error: could not compile `docforum-escrow` (lib) due to 8 previous errors; 4 warnings emitted

The contract code references event_destination, escrow_id, payer, destination and token in a scope where none of them exist. A block was probably pasted outside the function it belongs to. Run cargo build in contracts/escrow locally, then regenerate the bindings.

[github-actions]

@shakourllahfashola-dev This PR now has merge conflicts with main, most likely because #260 (feat(perf): profile and optimize status reads) was just merged, so it can't be merged until it's rebased:

git fetch upstream            # upstream = https://github.com/DocForum/docforum-escrow.git
git rebase upstream/main
# resolve the conflicts, re-run the tests, then:
git push --force-with-lease

The usual culprits are shared docs like ROADMAP.md and ARCHITECTURE*.md. If the conflict is in the ROADMAP.md changelog, move your entry into a new file under changelog.d/ (see changelog.d/README.md) rather than resolving it in place, so it can't conflict again. CI re-runs when you push, and the needs-rebase label is removed automatically once the conflicts are resolved.

_{Automated message. It won't repeat unless the PR conflicts again after your next push.}

[shakourllahfashola-dev]

Kindly review.

[afeezorobsco-cyber]

@shakourllahfashola-dev After updating this branch with main, CI fails at the new "Require a contract version bump when lib.rs changes" step (added by #153, merged today):

contracts/escrow/src/lib.rs changed without a CONTRACT_VERSION bump

Please bump pub const CONTRACT_VERSION: &str = "..."; in contracts/escrow/src/lib.rs, regenerate anything that changes as a result (test snapshots, SDK bindings), and push. Everything else is green.

[github-actions]

@shakourllahfashola-dev This PR now has merge conflicts with main, most likely because #242 (feat(contract): per-token liability accounting and solvency view) was just merged, so it can't be merged until it's rebased:

git fetch upstream            # upstream = https://github.com/DocForum/docforum-escrow.git
git rebase upstream/main
# resolve the conflicts, re-run the tests, then:
git push --force-with-lease

The usual culprits are shared docs like ROADMAP.md and ARCHITECTURE*.md. If the conflict is in the ROADMAP.md changelog, move your entry into a new file under changelog.d/ (see changelog.d/README.md) rather than resolving it in place, so it can't conflict again. CI re-runs when you push, and the needs-rebase label is removed automatically once the conflicts are resolved.

_{Automated message. It won't repeat unless the PR conflicts again after your next push.}

[afeezorobsco-cyber]

@shakourllahfashola-dev Heads-up: #268 just changed how contract PRs work in this repo. Your PR changes contracts/escrow/src/lib.rs, so CI's new "Contract changes use a fragment, not a version bump" step will fail it until you make these changes (details in contract-changes.d/README.md):

1. Don't edit CONTRACT_VERSION when you merge main (currently 2.3.0). Keep main's line as it is.

2. Add a fragment, e.g. contract-changes.d/9-feat-contract-emit-lifecycle-events-on-c.md:

   bump: minor
   ---
   Issue #9: one-paragraph summary of the contract change.

   Use patch for a behaviour fix with no interface change, minor for new entry points, arguments, events or errors, and major for breaking changes.

3. If you add any new Error variants, give them provisional codes (issue number × 100 + n, e.g. 900) and never renumber existing ones.

This should also make your next merge from main much easier: the version line was the one thing every contract PR conflicted on.

[afeezorobsco-cyber]

Sweep: malware scan clean, CI green.