Repository navigation
feat(cli): add escrow operator command - #194
nasirudeenbadirudeen87-cloud wants to merge 4 commits into
Conversation
|
@nasirudeenbadirudeen87-cloud Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@afeezorobsco-cyber, please review and merge once the checks pass. The local-network E2E run is noted in the PR as blocked by the unavailable Docker daemon. |
|
This PR has merge conflicts with |
|
@nasirudeenbadirudeen87-cloud Thanks for the PR. It can't be merged yet. To unblock it: CI is failing. Here's what broke:
Please fix these errors and run the same steps locally before pushing ( Merge conflicts: this branch conflicts with Push to this same branch and CI will re-run. Once it's green and conflict-free, it'll be reviewed for merge. |
✅ Malware scan: cleanThe earlier findings are resolved as of |
1ba230e to
329f076
Compare
|
@nasirudeenbadirudeen87-cloud This PR now has merge conflicts with git fetch upstream # upstream = https://github.com/DocForum/docforum-escrow.git
git rebase upstream/main
# resolve the conflicts, re-run the tests, then:
git push --force-with-leaseThe usual culprits are shared docs like Automated message. It won't repeat unless the PR conflicts again after your next push. |
|
@nasirudeenbadirudeen87-cloud This PR now has merge conflicts with git fetch upstream # upstream = https://github.com/DocForum/docforum-escrow.git
git rebase upstream/main
# resolve the conflicts, re-run the tests, then:
git push --force-with-leaseThe usual culprits are shared docs like Automated message. It won't repeat unless the PR conflicts again after your next push. |
1 similar comment
|
@nasirudeenbadirudeen87-cloud This PR now has merge conflicts with git fetch upstream # upstream = https://github.com/DocForum/docforum-escrow.git
git rebase upstream/main
# resolve the conflicts, re-run the tests, then:
git push --force-with-leaseThe usual culprits are shared docs like Automated message. It won't repeat unless the PR conflicts again after your next push. |
Upstream already ships EscrowSigner/signerAddress, so the index.ts changes from this branch are dropped in favour of main's. Pass the new notify_payee/refund_to fields from the CLI's create path. Compile the Node-only CLI through tsconfig.cli.json so @types/node does not leak into the cross-runtime library build, and run tests/cli-args.test.ts as part of test:unit now that CI calls the explicit test scripts.
|
@nasirudeenbadirudeen87-cloud This PR now has merge conflicts with git fetch upstream # upstream = https://github.com/DocForum/docforum-escrow.git
git rebase upstream/main
# resolve the conflicts, re-run the tests, then:
git push --force-with-leaseThe usual culprits are shared docs like Automated message. It won't repeat unless the PR conflicts again after your next push. |
|
@afeezorobsco-cyber I merged current |
|
@afeezorobsco-cyber PR #194 is current-main mergeable and its malware scan passed. The CLI-specific typecheck and argument tests passed locally. The full SDK build still reports two TypeScript errors in existing factory.ts under the local Node 26 / TypeScript 5.9 toolchain; please check the required CI workflow state and review the CLI changes. |
|
@nasirudeenbadirudeen87-cloud (cc @Ruruxy, who pushed the latest merge) Every TypeScript SDK job now fails at the build step: Merge |
|
@nasirudeenbadirudeen87-cloud This PR now has merge conflicts with git fetch upstream # upstream = https://github.com/DocForum/docforum-escrow.git
git rebase upstream/main
# resolve the conflicts, re-run the tests, then:
git push --force-with-leaseThe usual culprits are shared docs like Automated message. It won't repeat unless the PR conflicts again after your next push. |
Summary
docforum-escrowCLI for create, status, show, release, refund, and contract event listing.Signerobjects. Secrets are rejected in argv; state changes require confirmation;--dry-run,--json, and explicit mainnet opt-in are supported.Closes #88
Verification
npm ci— passednpm run typecheck— passednpm run build— passednpm test— 3 parser tests passednpm pack --dry-run— passed; CLI is included in the packagenpm ci,npm run typecheck, andnpm run build— passed before the CI changenpm run test:integration— 2 of 5 live testnet tests failed after Friendbot/RPC connection timeouts; 3 passed~/.docker/run/docker.sockis missing)The local-network E2E run remains the verification gap; the CLI is ready for that check once a local Stellar container can start.