Repository navigation
feat(escrow): support attested releases - #167
aduagba4133 wants to merge 1 commit into
Conversation
|
@aduagba4133 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
This PR has merge conflicts with |
|
@aduagba4133 Thanks for the PR. It can't be merged yet. To unblock it: CI is failing. Here's what broke:
Please fix these errors and run the same steps locally before pushing ( Merge conflicts: this branch conflicts with Push to this same branch and CI will re-run. Once it's green and conflict-free, it'll be reviewed for merge. |
|
Hi @afeezorobsco-cyber — I reviewed the conflict and CI failure. The branch conflicts across the contract data model, settlement entry points, generated SDK bindings, SDK source/package metadata, and tests; its older CI also fails on a Soroban SDK |
|
@aduagba4133 Heads-up: #268 just changed how contract PRs work in this repo. Your PR changes
This should also make your next merge from |
Summary
Closes #42
Verification
cargo test --manifest-path contracts/escrow/Cargo.tomlpassed (33 tests).cargo build --manifest-path contracts/escrow/Cargo.toml --target wasm32v1-none --releasepassed.sdk/src/generated/contract-client.tsfrom the compiled Wasm.git diff --checkandrustfmt --checkpassed.