fix(config): format message-tone error with clean comma-separated list (#717) - #733
Open
harmehak0173 wants to merge 3 commits into
Open
harmehak0173 wants to merge 3 commits into
harmehak0173 wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice
What this PR does
Fixes the error message when an invalid message tone is configured. Previously,
MESSAGE_TONESwas formatted directly into the f-string, printing a raw Python tuple representation (('human', 'technical')). It is now formatted as a clean, human-readable comma-separated string (choose one of: human, technical).Tests added (run in CI)
tests/unit/test_message_tone.py:test_save_rejects_an_unknown_tone: verifies exact error message pattern and confirms raw tuple formatting('is absent.test_cli_rejects_an_invalid_tone: verifies CLI error output and confirms raw tuple formatting('is absent.Changelog
changelog.d/724.fixed.mdfragment addedPublic-release safety (doberman-core only)
Security checklist
Edge cases covered / Deviations from plan / Risks introduced
None.
Fixes #717