Repository navigation
test: prune redundant unit tests per testing-trophy audit - #237
Merged
Merged
Conversation
Remove or merge unit cases that duplicate higher-tier coverage or only echo implementation, and drop the unused bucketTimestamps export. Cases with unique assertions (parsers, fingerprinting, CSV injection, queue/retry/concurrency) are kept.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes or merges ~55 unit cases that duplicate integration coverage or only echo implementation (602 → ~547 unit cases across app and SDKs), and deletes the unused
bucketTimestampsexport plus the duplicateretention.unit.test.ts.Kept: parsers, fingerprinting, CSV injection, queue loss/order/retry/concurrency, and any case with an assertion not covered by a higher tier. Where a removed row had unique value it was folded into an existing table or integration test.
Verified locally: app unit/integration/component,
vp check, svelte-check, knip; TS SDK unit/integration/build/lint; Go-race+ vet; Python pytest/ruff/mypy (isolated container).