Repository navigation
Conversation
Author
|
this PR is ready for another review. I resolved the merge conflicts with the main branch (pushed fe4eb8e). |
Author
|
this PR is ready for another review. I resolved the merge conflicts with the main branch (pushed 59199bf). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a bounded audit record for every published Lens price aggregate. Each record captures the inputs the aggregate used, the inputs it rejected and why, and the method plus its parameters, so a disputed price can be reconstructed for a past timestamp. Records are retrievable via the price route, and storage growth is bounded and documented.
Related Issue
Changes
🧾 Aggregate Audit Records
[MODIFY]
prisma/schema.prismaPriceAuditRecordmodel keyed to the published aggregate (network, pairKey, timestamp) with the method, method parameters, and a bounded input set.PriceAuditInputmodel for per-input entries: the referencedprice_pointsrow, whether it was used or rejected, and the rejection reason.networkpredicate on the audit lookups so the composite index is usable, matching theprice_pointsaccess pattern.[MODIFY]
src/routes/price.ts[MODIFY]
docs/database-schema.mdVerification Results
PriceAuditInputstores used/rejected flag and rejection reasonsrc/routes/price.tsretrieves the record for a past timestampdocs/database-schema.mdCloses #245