Repository navigation
fix(validation): reject invalid Stellar keys and inconsistent vault c… - #1766
Merged
1nonlypiece merged 2 commits intoOct 24, 2026
Merged
1nonlypiece merged 2 commits into
1nonlypiece merged 2 commits into
Conversation
…onfigs on POST /vaults
…e conflicts Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1684
Summary
Replaces regex-only address validation and loose date/milestone rules on
POST /vaultswith a schema inapilib/validation.mjs(usingzodand@stellar/stellar-sdk) that matches the contract invariants and prevents invalid vaults from being accepted by the API.Changes
StrKey.isValidEd25519PublicKeyoncreator,verifier,successDestination, andfailureDestination. Explicitly rejects muxedM...addresses.verifier !== creatorandfailureDestination !== creator. Invalid optional destinations reject with 400 rather than silently falling back.startDate >= now - 5min(clock skew),endDate > startDate, andendDate - now <= 5 years. Date strings without timezone offsets are treated as UTC.startDate < dueDate <= endDate, and non-decreasing due dates.400 { error: 'Validation failed', details: [{ field, code, message }] }without echoing raw inputs.apilib/openapi.mjsto reflect constraints and structured error details.apilib/__tests__/validation.test.mjscovering all positive and negative constraints, including checksum corruption.api/__tests__/vaults.create.test.mjsasserting response envelope shape and status codes.