Repository navigation
fix(api): return JSON 4xx errors for malformed bodies and invalid query parameters - #1764
Merged
1nonlypiece merged 2 commits intoOct 24, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1686
Summary of Changes
apilib/query.mjswith validators forstatus,creator, andvaultId. Applied them acrossGET /vaults,GET /transactions, andGET /stats. Array query params and invalid formats now cleanly return 400 JSON errors naming the invalid parameter.entity.parse.failed-> 400Malformed JSON body,entity.too.large-> 413, unsupported charset/encoding -> 415) and safe 500 JSON responses without stack or DB error leakage.Content-Type: application/jsonforPOSTroutes (returning 415 JSON) and added 405 Method Not Allowed handling withAllowheader for known paths.GET /vaults,GET /transactions, andGET /stats.apilib/__tests__/query.test.mjs) and integration tests (api/__tests__/errors.test.mjs) testing all acceptance criteria and parameterized fuzzing across all OpenAPI paths.