Prevent schedule date mutation during timezone calculations#9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
When a timezone-aware schedule calculated its next occurrence,
getNextOccurrence()calledsetTimezone()directly on theCarbonInterfaceinstance it received. If the caller passed a mutableCarboninstance, that call changed the caller's object in place.That could leak the schedule's timezone back into calling code that expected its original date object to remain unchanged after asking the driver for the next run time.
Fix
The schedule driver now calls
avoidMutation()before applying the schedule timezone. This preserves the existing timezone-aware calculation behavior while preventing mutable input dates from being modified.Tests
Carboninstance remains in UTC after a timezone-aware next occurrence calculation../vendor/bin/pest../vendor/bin/pint --dirty.