Skip to content

refactor: harden site consent, freshness, and deploy integrity - #1

Merged
Dingding-leo merged 22 commits into
mainfrom
refactor/site-trust-performance
Aug 16, 2026
Merged

refactor: harden site consent, freshness, and deploy integrity#1
Dingding-leo merged 22 commits into
mainfrom
refactor/site-trust-performance

Conversation

@Dingding-leo

Copy link
Copy Markdown
Owner

Direction

Preserve the existing Last Blue Hour visual identity. This is a trust, performance, maintainability, and deployment-integrity pass rather than a redesign.

Visitor experience

  • make ambience opt-in for first-time visitors; an intentional Play action is now required before sound starts
  • retain the saved preference for visitors who previously enabled ambience
  • clarify Austin's public identity as a dental student in Adelaide and independent builder without changing the cinematic presentation
  • keep native sharing hydration-safe and remove an invalid decorative ARIA attribute

Fresh deployments and offline behavior

  • version the service-worker registration with the current build SHA
  • reload once when a new worker replaces an already-controlled page, preventing stale HTML from requesting deleted chunks
  • isolate page/static caches per build while keeping a bounded reusable media cache
  • leave streamed audio/video and byte-range requests to the browser
  • preserve the independent /KnightClub/ and /Denki/ service-worker scopes

Code and dependency health

  • upgrade and pin Next.js to 16.3.1
  • resolve the production dependency advisories found by npm audit
  • restore supported ESLint 9 + eslint-config-next validation
  • remove the unused 1,459-line legacy Site.tsx
  • remove the obsolete synthetic sound engine; the live experience continues to use the recorded ambience engine
  • simplify duplicated hydration and mount-only state paths in sharing, projects, audio volume, and chapter selection

Static-export integrity

  • add an export validator that checks internal links, assets, srcset entries, hash fragments, required SEO/PWA files, manifest JSON, and service-worker syntax
  • make npm run check run lint, TypeScript, the complete static export, and export validation
  • require a clean high-severity production audit before CI or GitHub Pages deployment succeeds
  • standardize CI and deployment on Node.js 22 with a build-specific service-worker ID

Verification

The branch has already passed source linting, TypeScript, the Next.js 16 static export, validation of 20 pages and 1,213 internal references, service-worker syntax checks, and a clean production dependency audit.

Copilot AI lite review requested due to automatic review settings August 16, 2026 15:27
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Dingding-leo
Dingding-leo merged commit b96b12e into main Aug 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants