Skip to content

Add cam and webcam devices#2032

Draft
jacob720 wants to merge 4 commits intoupdate_dodal_ophyd_async_v0.17a1from
cryst_bluesky_20_add_i15_cams
Draft

Add cam and webcam devices#2032
jacob720 wants to merge 4 commits intoupdate_dodal_ophyd_async_v0.17a1from
cryst_bluesky_20_add_i15_cams

Conversation

@jacob720
Copy link
Copy Markdown
Contributor

Adds camera devices to i15-1 for DiamondLightSource/crystallography-bluesky#20
The webcams won't connect due to an issue in ophyd-async, fixed in bluesky/ophyd-async#1225. This should resolve once we get onto a new version of ophyd-async.

Instructions to reviewer on how to test:

  1. Do dodal connect i15_1
  2. Confirm the 3 cams connect (webcams are expected to fail)

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@jacob720 jacob720 requested a review from a team as a code owner April 28, 2026 09:51
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.05%. Comparing base (32e05ec) to head (2c6c528).

Additional details and impacted files
@@                        Coverage Diff                        @@
##           update_dodal_ophyd_async_v0.17a1    #2032   +/-   ##
=================================================================
  Coverage                             99.05%   99.05%           
=================================================================
  Files                                   325      325           
  Lines                                 12662    12687   +25     
=================================================================
+ Hits                                  12542    12567   +25     
  Misses                                  120      120           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jacob720 jacob720 marked this pull request as draft April 29, 2026 11:04
@jacob720 jacob720 force-pushed the cryst_bluesky_20_add_i15_cams branch from b790510 to f974f53 Compare April 30, 2026 08:54
@jacob720 jacob720 changed the base branch from main to update_dodal_ophyd_async_v0.17a1 April 30, 2026 12:32
@jacob720 jacob720 marked this pull request as ready for review April 30, 2026 16:20
@jacob720 jacob720 marked this pull request as draft April 30, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant