Skip to content

feat: make ECR push CI/CD generic so that repo can be swapped when pa… #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sclaw merged 1 commit into from
Oct 7, 2026
Merged

feat: make ECR push CI/CD generic so that repo can be swapped when pa… #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/ecr-image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ permissions:
id-token: write

jobs:
push:
push-image-to-ecr:
if: github.ref == 'refs/heads/master'
runs-on: ubuntu-latest
steps:
Expand All @@ -27,7 +27,7 @@ jobs:
role-to-assume: ${{ vars.ECR_PUSH_ROLE_ARN }}
aws-region: ${{ vars.AWS_REGION }}
- name: Verify ECR repository
run: aws ecr describe-repositories --repository-names flows2fim --query 'repositories[0].repositoryName' --output text > /dev/null
run: aws ecr describe-repositories --repository-names ${{ vars.ECR_REPOSITORY_NAME }} --query 'repositories[0].repositoryName' --output text > /dev/null
- uses: aws-actions/amazon-ecr-login@v2
id: login
- uses: docker/setup-buildx-action@v3
Expand All @@ -37,4 +37,6 @@ jobs:
target: prod
push: true
platforms: linux/amd64,linux/arm64
tags: ${{ steps.login.outputs.registry }}/flows2fim:sha-${{ github.sha }}
tags: |
${{ steps.login.outputs.registry }}/${{ vars.ECR_REPOSITORY_NAME }}:sha-${{ github.sha }}
${{ steps.login.outputs.registry }}/${{ vars.ECR_REPOSITORY_NAME }}:latest
4 changes: 2 additions & 2 deletions .github/workflows/infrastructure.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ permissions:
contents: read

jobs:
validate:
validate-cdk-build:
if: github.event_name == 'pull_request'
runs-on: ubuntu-latest
defaults:
Expand All @@ -35,7 +35,7 @@ jobs:
- run: uv run --locked pyright
- run: uv run --locked cdk synth

deploy:
deploy-ecr-repo-with-cdk:
if: github.ref == 'refs/heads/master' && github.event_name != 'pull_request'
runs-on: ubuntu-latest
defaults:
Expand Down
Loading