Repository navigation
Feature/nctcog integration - #1
Merged
Merged
Conversation
…atabase instead of deriving from an implicit file structure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support NCTCOG integration with explicit FIM paths and ECR deployment
Decouple FIM discovery from a fixed directory layout so scenario data can point to maps stored in external library layouts, and add AWS ECR infrastructure and workflows to validate and publish the container image.
Additions
fim_pathscenario column to controls output, with actionable errors and SQL guidance for databases that do not yet provide the column.fim_pathbehavior.Removals
validate's-o_unexpected_fimsoutput and the check that inferred unexpected scenarios from the legacy folder structure.<reach_id>/z_<stage>/f_<flow>.tiffor compositing and validation.Changes
fimnow reads paths from the controls file'sfim_pathcolumn, resolving relative paths against-lib; absolute and GDAL VSI paths are used as-is.validatematches library TIFFs against scenariofim_pathvalues and updates its output columns.domain.tifretains its existing per-reach location when requested.Testing
fim_pathoutput, mapless scenarios, and rejection of controls files without the path column. These suites were not run while preparing this description.cdk synthfor pull requests; these checks were not run locally.git diff --check origin/master...HEADreports trailing whitespace in.github/workflows/infrastructure.yml; remove it and rerun the check.Screenshots
Not applicable; this PR changes CLI, data, and infrastructure behavior without a user interface.
Notes
controlsandvalidaterequirescenarios.fim_path. Use a compatible ripple1d-pipeline database or apply the SQL backfill printed by the command for libraries using the legacy layout.AWS_REGION,ECR_PUSH_ROLE_ARN,CDK_DEPLOY_ROLE_ARN, andCFN_EXECUTION_ROLE_ARN.masterbut no localmainref; the comparison and checks above useorigin/master. Confirm the intended GitHub PR base.Todos
git diff --check.Checklist
Testing checklist
Target Environment support
Accessibility
Other