Unloaded chunk issue - #3
Open
MlsDmitry wants to merge 2 commits into
Open
Conversation
DenielWorld
requested changes
Apr 24, 2020
DenielWorld
left a comment
DenielWorld
left a comment
Owner
There was a problem hiding this comment.
Please address the commented changes first, and then I will review the PR again for a merge.
|
|
||
| use DenielWorld\EzTiles\data\TileInfo; | ||
| use DenielWorld\EzTiles\EzTiles; | ||
| use InvalidArgumentException; |
| use pocketmine\nbt\tag\ShortTag; | ||
| use pocketmine\nbt\tag\StringTag; | ||
| use pocketmine\tile\Spawnable; | ||
| use ReflectionClass; |
Owner
There was a problem hiding this comment.
This is unnecessary as well.
| use pocketmine\nbt\tag\StringTag; | ||
| use pocketmine\tile\Spawnable; | ||
| use ReflectionClass; | ||
| use ReflectionException; |
Owner
There was a problem hiding this comment.
Also unnecessary. Qualifier imports are often unneeded and an \ should be fine.
| //Don't mind this, it is for tile recreation after restart which is no longer handled by you. | ||
| if($tileInfo instanceof CompoundTag) { | ||
|
|
||
| $level->loadChunk($this->x >> 4, $this->z >> 4); // fix unloaded chunk at 0 0 issue |
Owner
There was a problem hiding this comment.
Are you sure this issue only occurs on tile recreations? Or is it possible that it could happen while constructing the tile for the first time?
| if(is_int($key)) $key = (string)$key; | ||
| if(is_object($value) or is_callable($value)) { | ||
| throw new \InvalidArgumentException("Callable and objects cannot be saved to NBT"); | ||
| throw new InvalidArgumentException("Callable and objects cannot be saved to NBT"); |
Owner
There was a problem hiding this comment.
Clear qualifier imports, stick to \
| switch ($this->getArrayType($value)){ | ||
| case self::TAG_INVALID: | ||
| throw new \InvalidArgumentException("Arrays can only contain one type of data, bool or int only"); | ||
| throw new InvalidArgumentException("Arrays can only contain one type of data, bool or int only"); |
Owner
There was a problem hiding this comment.
Clear qualifier imports, stick to \
| break; | ||
| case self::TAG_INVALID: | ||
| throw new \InvalidArgumentException("Invalid tag provided"); | ||
| throw new InvalidArgumentException("Invalid tag provided"); |
Owner
There was a problem hiding this comment.
Clear qualifier imports, stick to \
| { | ||
| if($this->callable !== "") { | ||
| $reflection = new \ReflectionClass(EzTiles::getRegistrant()); | ||
| $reflection = new ReflectionClass(EzTiles::getRegistrant()); |
Owner
There was a problem hiding this comment.
Clear qualifier imports, stick to \
| //TODO: Use switch() | ||
| if(is_object($value) or is_callable($value)) { | ||
| throw new \InvalidArgumentException("Callable and objects cannot be saved to NBT"); | ||
| throw new InvalidArgumentException("Callable and objects cannot be saved to NBT"); |
Owner
There was a problem hiding this comment.
Clear qualifier imports, stick to \
| * Executed upon tile update, if it is scheduled & if a callable method string is provided | ||
| * @return bool | ||
| * @throws \ReflectionException | ||
| * @throws ReflectionException |
Owner
There was a problem hiding this comment.
Clear qualifier imports, stick to \
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.