Repository navigation
refactor: move mapping logic from services to mapper class - #54
Merged
Merged
Conversation
A new method `ToCardDTOList` was added to the `Mapper` class in `Mapper.cs` to convert an `IEnumerable<BaseCard>` to a `List<BaseCardDto>`. This change replaces the previous `foreach` loop and `switch` statement in both the `CardsService` and `StacksService` classes with a call to the new method, simplifying the code and enhancing maintainability. This refactor improves the overall structure and readability of the card conversion logic.
Added a new method `ToStudySessionDTOList` in the `Mapper` class to convert a collection of `StudySession` objects into a list of `StudySessionDto` objects using LINQ. Updated the `StudySessionsService` class to utilize this new method, replacing a manual loop for conversion. This change simplifies the code and enhances readability by leveraging the new mapping functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request moves mapping logic from services to mapper class.
Changes
Mapper.cs: Added methodsToStackDTOList,ToCardDTOList, andToStudySessionDTOListfor batch conversion of entities to DTOs.CardsService.cs: Refactored to useMapper.ToCardDTOList, replacing manual iteration for card conversion.StacksService.cs: Updated to utilizeMapper.ToStackDTOListfor stack DTO conversion, improving clarity.StudySessionsService.cs: Modified to employMapper.ToStudySessionDTOList, simplifying study session DTO conversion.