Repository navigation
feat: add Leitner system handling in StudySessionsService - #45
Merged
Merged
Conversation
This change introduces an asynchronous operation to open a SQL connection in the `CardsRepository` class. By using `await connection.OpenAsync();`, the connection to the database is established without blocking the calling thread, enhancing the efficiency of the operation.
Added a new dependency on `ICardsRepository` in the `StudySessionsServiceTests` class, updating the constructor and service instantiation. Mocked `_cardsRepository.UpdateCardsProgressBulkAsync` to simulate card progress updates. Updated the `StartStudySessionAsync_ShouldResetScore_WhenCalledMultipleTimes` test to await asynchronous calls, improving test coverage and ensuring proper handling of async operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request implements Leitner system handling in StudySessionsService.
Changes
CardsRepository.cs: Added asynchronous connection opening for bulk updates.IStudySessionsService.cs: ChangedStartStudySessionAsyncto returnTask<Result>.StudySessionsService.cs: Introduced dependency onICardsRepositoryand modifiedStartStudySessionAsyncto be asynchronous.StudySessionsService.cs: Added private methodsGetNextBoxandGetNextReviewDatefor determining card progress.StudySessionsService.cs: UpdatedRunStudySessionAsyncto awaitStartStudySessionAsyncfor improved error handling.StudySessionsService.cs: Added Leitner system handling.