fix: data/*.json excluded from published package - #8
Merged
Merged
Conversation
- generation_param_defaults.json was silently excluded from the published package (confirmed by inspecting the actual PyPI 2.9.4 sdist) — hatchling's default file selection re-applies .gitignore's blanket *.json rule at build time, independent of the file being force-added to git - force-include data/*.json in both wheel and sdist targets - add CI job that builds the wheel, installs it in a clean venv, and smoke- tests that generation_defaults actually loads — existing tests only ever ran against source, never caught this - bump version to 2.9.5
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
generation_param_defaults.json shipped in git but not in the built wheel/sdist
that got published as 2.9.4 — confirmed by downloading the actual PyPI
package and listing its contents.
Root cause
.gitignore's blanket *.json rule gets re-applied by hatchling at build time
regardless of the file being force-committed to git. Fixed at the source —
explicit force-include in the wheel/sdist build targets — plus a new CI job
that installs the built wheel in a clean venv and smoke-tests it, so this
class of bug can't pass CI silently again.
Verified against the real artifact, not just tests
Built wheel + sdist locally, listed contents to confirm the file is present,
installed the wheel into a clean venv, ran a full scan against demo/sample-repo,
confirmed generation-param provenance resolves correctly (framework_default/
not_applicable tiers populate, nothing silently degrades to unknown).