Add XML support for Checkmarx CxFlow SAST parser and regression test#15049
Open
goutham-hari wants to merge 1 commit into
Open
Add XML support for Checkmarx CxFlow SAST parser and regression test#15049goutham-hari wants to merge 1 commit into
goutham-hari wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Checkmarx CxFlow SAST parser (
dojo/tools/checkmarx_cxflow_sast/parser.py)previously only supported JSON report imports — XML files hit a TODO stub and
returned no findings.
This PR adds XML support by delegating to the existing
CheckmarxParser(
dojo/tools/checkmarx/parser.py, detailed mode) instead of duplicating itsparsing logic.
Test results
Added
test_xml_parse_file_with_single_vulnerability_has_single_findinginunittests/tools/test_checkmarx_cxflow_sast_parser.py, using the existingsample file
checkmarx/single_finding.xml. Verifies a single finding isreturned with the correct title, "High" severity, active=True, verified=False.
Documentation
No documentation changes — this extends file-format support within the existing
Checkmarx CxFlow SAST parser; no new parser/page is introduced.
Extra information
No pre-approval issue was filed for this one, given the narrow scope (closing a
TODO/format gap in an existing parser rather than adding a new integration).
Happy to open one if a maintainer would prefer that first.