Conversation
|
Finding from the portal↔openauth reconciliation (PR #9): this feature is already live in portal — portal PR 484 ("Enable current users to grant Github orgs to Defang", merged 2026-02-10) contains the identical I rebased this branch onto the reconciliation branch to check: the feature commit collapses to empty (already upstream); the only survivor is a 2-line prettier fix in Suggestion: once PR #9 lands in |
|
The prompt feature already landed in portal via portal PR 484; the surviving 2-line prettier fix is included in https://github.com/DefangLabs/portal/pull/947. The subtree at |
There is not prompt field in the
AuthorizationStateby allowing this we are able to do the following.The openauth package doesn't forward the prompt parameter from our app to GitHub. So when we tell it "hey, ask the user for consent again," it just ignores us and does a normal login.
We need two small plumbing changes inside openauth to pass prompt through:
internal /github/authorize?prompt=consent route
https://github.com/login/oauth/authorize?...&prompt=consent
Without both, the prompt=consent gets dropped along the way and GitHub never sees it.
This PR will solve this. There was PR in portal related to this: https://github.com/DefangLabs/portal/pull/484.
There no need to merge this PR unless we want to sync the Git subtree.