Correct C++ update + reorganizing Module bindings#64
Open
hschreiber wants to merge 10 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For homogeneity, I would do the same for
SummandandBoxas a next step. Are there some methods you would like to add to the bindings of those two classes, while I am at it? (by default I will at least add__setstate__/__getstate__for both)Note that I added the method
summands_of_dimension_rangeto the Module bindings (to use likefor s in mod.summands_of_dimension_range(d): ...), which you could use instead ofget_module_of_degreeif no copy is needed.And please verify that I didn't forgot to add the latest changes you made to the Module bindings.
Edit: Did the changes for the
SummandandBoxbindings in this PR in the end as it was quick.For the changes in the
AIDA.ipynbnotebook, I just replaced the end of box 15 with: