perf(pointer): cache element bounds for pointer interactions - #46
Merged
Conversation
Avoid repeated getBoundingClientRect calls in pointermove handlers by caching element bounds and refreshing them on layout changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR improves pointer interaction performance across the Vanilla implementations used by the Vue, Solid, and Svelte components.
getBoundingClientRect()was being called inside 20 high-frequencypointermovehandlers. The element bounds are now cached and refreshed only when the layout can change, such as during resize or scroll. The cache and its event listeners are also cleaned up when the component is destroyed.This change reduces unnecessary main-thread work during pointer movement and makes interactive effects more responsive, especially on lower-end devices or when multiple effects are active.
Benchmark
Chromium headless benchmark across 20 pointer handlers and 4,000,000 total iterations:
Type of change
Checklist
npx tsc --noEmitpassesnpm run lintpassesnpm run buildpasseshtml-in-canvasflag, if relevant)