Skip to content

Fix/preact effect dependencies - #45

Merged
DavidHDev merged 28 commits into
DavidHDev:mainfrom
phh235:fix/preact-effect-dependencies
Aug 18, 2026
Merged

Fix/preact effect dependencies#45
DavidHDev merged 28 commits into
DavidHDev:mainfrom
phh235:fix/preact-effect-dependencies

Conversation

@phh235

@phh235 phh235 commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes stale subscription risks in the Preact component adapters by adding the missing subscribe
and getSnapshot dependencies to their internal synchronization effects.

This keeps the external-store snapshot and subscription in sync if either function changes.

Type of change

  • Bug fix

Checklist

  • npx tsc --noEmit passes
  • npm run lint passes
  • npm run build passes
  • Tested in Chrome (with the html-in-canvas flag, if relevant)
  • Tested the WebGL overlay fallback (flag off / Safari / Firefox), if a component changed

phh235 added 28 commits August 14, 2026 20:18
@DavidHDev
DavidHDev merged commit 214fe79 into DavidHDev:main Aug 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants