Skip to content

feat: add ci tests - #5

Merged
DaviAlcanfor merged 1 commit into
mainfrom
feat/ci-tests
Jun 23, 2026
Merged

DaviAlcanfor merged 1 commit into
mainfrom
feat/ci-tests

Conversation

@DaviAlcanfor

@DaviAlcanfor DaviAlcanfor commented Jun 23, 2026 •

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Tests

    • Added comprehensive test suite for cleaning utilities, validating UUID removal, content normalization, and summary line parsing.
    • Added test suite for summarizer utilities, verifying prompt generation and summary parsing functionality.
    • Added test fixtures providing sample source data for test usage.
  • Chores

    • Removed temporary development scripts.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026 •

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4a85f0f8-4470-45d4-8e26-dab3da9e1b97

📥 Commits

Reviewing files that changed from the base of the PR and between bd086aa and 2535272.

📒 Files selected for processing (5)
  • tests/conftests.py
  • tests/test_cleaning.py
  • tests/test_summarizer.py
  • tests/tmp_check.py
  • tests/tmp_sources.py

📝 Walkthrough

Walkthrough

Adds tests/conftests.py with two shared pytest fixtures (sample_sources, title_to_id), tests/test_cleaning.py covering _remove_uuid_only_lines, _clean_content, and _parse_summary_line, and tests/test_summarizer.py covering _build_summary_prompt and _parse_summaries. Removes two temporary scripts (tmp_check.py, tmp_sources.py).

Changes

Test Suite for Cleaning and Summarizer Helpers

Layer / File(s) Summary
Shared pytest fixtures
tests/conftests.py
Defines sample_sources (list of two id/title dicts) and title_to_id (title→id mapping) fixtures for use across the test suite.
Cleaning helper tests
tests/test_cleaning.py
TestRemoveUuidOnlyLines, TestCleanContent, and TestParseSummaryLine cover UUID-only line removal, CDN URL and image token stripping, newline normalization, whitespace trimming, and [Title]: Summary parsing including edge cases.
Summarizer helper tests
tests/test_summarizer.py
TestBuildSummaryPrompt verifies title_to_id mapping and prompt text; TestParseSummaries verifies structured parsing, unmatched title skipping, blank line handling, and output key correctness.
Remove temporary scripts
tests/tmp_check.py, tests/tmp_sources.py
Deletes two ad-hoc scripts that manually invoked NotebookLMAPI and printed results to stdout.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 Hop hop, the tmp scripts are gone,
No more printing sources at dawn.
Fixtures planted, clean and neat,
UUIDs scrubbed, summaries complete.
The warren's tests now stand firm — hop on! 🌿

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/ci-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@DaviAlcanfor
DaviAlcanfor merged commit 955d97b into main Jun 23, 2026
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant