Update ESLint and TypeScript to next major version - #979
Open
oeninghe-dataport wants to merge 2 commits into
Open
oeninghe-dataport wants to merge 2 commits into
oeninghe-dataport wants to merge 2 commits into
Conversation
oeninghe-dataport
added
the
dependencies
|
oeninghe-dataport
force-pushed
the
update-eslint-10
branch
from
September 22, 2026 11:10
9ef23cb to
d9576fc
Compare
oeninghe-dataport
marked this pull request as ready for review
September 22, 2026 11:10
oeninghe-dataport
requested review from
czirkelbach,
dopenguin,
raschju and
warm-coolguy
as code owners
September 22, 2026 11:10
dopenguin
requested changes
Sep 22, 2026
| component, | ||
| locales, | ||
| storeModule: useFullscreenStore as PolarPluginStore, | ||
| storeModule: useFullscreenStore, |
Member
There was a problem hiding this comment.
Why is this no longer needed here and some other plugins but most other plugins need this?
| "handlebars": "^4.7.9" | ||
| }, | ||
| "dependencies": { | ||
| "eslint-plugin-import-x": "^4.17.1" |
Member
There was a problem hiding this comment.
Shouldn't this be a devDependency?
| "@commitlint/cli": "^21.2.2", | ||
| "@commitlint/config-conventional": "^21.0.2", | ||
| "@dataport/eslint-config-geodev": "^1.1.0", | ||
| "@dataport/eslint-config-geodev": "^2.0.0-alpha.3", |
Member
There was a problem hiding this comment.
As this PR doesn't yield any errors, I prefer releasing a v2.0.0 which can be added here.
Or would you like to wait with that until neostandard releases a new version other than the one added by this PR?
| "jsdom": "^30.1.0", | ||
| "jspdf": "^4.2.1", | ||
| "magic-string": "^0.30.18", | ||
| "magic-string": "^1.4.1", |
Member
There was a problem hiding this comment.
We intended to not yet update this as other vite-plugins still use the old version.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Instructions for local reproduction and review
Everything works as before.