Skip to content

Fix confusing reverseGeocode error #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
warm-coolguy wants to merge 2 commits into
base: next
Choose a base branch
from
+18 −3
Open

Fix confusing reverseGeocode error #970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f57fe4
fix(reverseGeocoder): change log severity of correct behaviour
warm-coolguy Sep 11, 2026
2baebf5
Merge branch 'next' into fix-confusing-error
warm-coolguy Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/plugins/reverseGeocoder/store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@ import { indicateLoading } from '@/lib/indicateLoading'

import { PluginId } from './types'
import { reverseGeocodeNominatim } from './utils/reverseGeocodeNominatim'
import { reverseGeocodeWps } from './utils/reverseGeocodeWps'
import {
addressMissingMessage,
reverseGeocodeWps,
} from './utils/reverseGeocodeWps'

/* eslint-disable tsdoc/syntax */
/**
Expand Down Expand Up @@ -108,7 +111,16 @@ export const useReverseGeocoderStore = defineStore(
return feature
} catch (error) {
if (!signal.aborted) {
console.error('Reverse geocoding failed:', error)
if (
error instanceof Error &&
error.message === addressMissingMessage
) {
console.warn(
`Reverse geocoding stopped with message '${addressMissingMessage}'. This indicates the WPS does not support this region.`
)
} else {
console.error('Reverse geocoding failed:', error)
}
}
return null
} finally {
Expand Down
5 changes: 4 additions & 1 deletion src/plugins/reverseGeocoder/utils/reverseGeocodeWps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ function getTextContent(parent: Element, localName: string) {
return parent.getElementsByTagNameNS('*', localName)[0]?.textContent ?? ''
}

export const addressMissingMessage =
'Response does not contain an "Adresse" element.'

export async function reverseGeocodeWps({
url,
coordinate,
Expand Down Expand Up @@ -61,7 +64,7 @@ export async function reverseGeocodeWps({

const address = doc.getElementsByTagNameNS('*', 'Adresse')[0]
if (!address) {
throw new Error('Response does not contain an "Adresse" element.')
throw new Error(addressMissingMessage)
}

// NOTE: Property names come from the WPS.
Expand Down
Loading