Repository navigation
feat(browser): support flag-key obfuscation #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b75d36a
feat(browser): support obfuscated precomputed flag keys
leoromanovsky 8af42e2
Merge main into browser-flag-key-obfuscation
leoromanovsky b6d1884
fix(browser): address obfuscation review and cache compatibility
leoromanovsky 74de79b
fix(browser): bound exposure caches and preserve proxy compatibility
leoromanovsky afa7d00
fix(browser): restore exposure resets on configuration changes
leoromanovsky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| // Match the Node provider's exposure cache limit. | ||
| export const MAX_EXPOSURE_CACHE_ENTRIES = 50_000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,47 +1,25 @@ | ||
| import { | ||
| type AbstractAssignmentCache, | ||
| type AssignmentCacheEntry, | ||
| NonExpiringInMemoryAssignmentCache, | ||
| } from '@datadog/flagging-core' | ||
| import { LRUInMemoryAssignmentCache } from '@datadog/flagging-core' | ||
|
|
||
| import { MAX_EXPOSURE_CACHE_ENTRIES } from './constants' | ||
| import type { BulkReadAssignmentCache, BulkWriteAssignmentCache } from './hybrid-assignment-cache' | ||
|
|
||
| /** An {@link BulkWriteAssignmentCache} assignment cache backed by an in-memory {@link Map} */ | ||
| export default class SimpleAssignmentCache implements BulkWriteAssignmentCache, BulkReadAssignmentCache { | ||
| private readonly store: Map<string, string> | ||
| private readonly cache: AbstractAssignmentCache<Map<string, string>> | ||
|
|
||
| /** A bounded in-memory exposure cache, also used to serve persisted entries. */ | ||
| export default class SimpleAssignmentCache | ||
| extends LRUInMemoryAssignmentCache | ||
| implements BulkWriteAssignmentCache, BulkReadAssignmentCache | ||
| { | ||
| constructor() { | ||
| this.store = new Map<string, string>() | ||
| this.cache = new NonExpiringInMemoryAssignmentCache(this.store) | ||
| } | ||
|
|
||
| init(): Promise<void> { | ||
| return Promise.resolve() | ||
| } | ||
|
|
||
| set(key: AssignmentCacheEntry): void { | ||
| this.cache.set(key) | ||
| } | ||
|
|
||
| has(key: AssignmentCacheEntry): boolean { | ||
| return this.cache.has(key) | ||
| super(MAX_EXPOSURE_CACHE_ENTRIES) | ||
| } | ||
|
|
||
| setEntries(entries: [string, string][]): void { | ||
| const { store } = this | ||
| // it's important to call store.set() directly here because we want to set the raw entries into the cache, bypassing | ||
| // the AbstractAssignmentCache logic, which takes an AssignmentCacheKey instead. | ||
| // Load serialized entries through the same capacity limit as new exposures. | ||
| entries.forEach(([key, value]) => { | ||
| store.set(key, value) | ||
| this.delegate.set(key, value) | ||
| }) | ||
| } | ||
|
|
||
| getEntries(): Promise<[string, string][]> { | ||
| return Promise.resolve(Array.from(this.cache.entries())) | ||
| } | ||
|
|
||
| clear(): void { | ||
| this.cache.clear() | ||
| return Promise.resolve(Array.from(this.entries())) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.