You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality.
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker, but I think we should have one cardinality_log_emitted per field, since we can collapse mutliple times with different cardinalities
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Send telemetry about per-field cardinality collapses.
Motivation
CSS spec compliance.
Additional Notes
Not a fan of how much I need to duplicate some parts of the code. But I wanted to avoid using HashMaps everywhere and keep the changes simple.
Maybe some sort of macro magic can solve this ? But I'm afraid it might hurt readability even more. I'm open to suggestions
How to test the change?
Describe here in detail how the change can be validated.